Skip to content

[typescript-fetch] runtime: pass init and url as returned by the premiddleware to the postmiddleware #9716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

FabianSellmann
Copy link
Contributor

@FabianSellmann FabianSellmann commented Jun 8, 2021

Current implementation will always pass the initial url and init object. However if a pre middleware returns an object whose init or url property refer to a different url string or object, any following post middleware wont have access to it. Effectively providing the post middleware with completely different request information then what was actually used to make the fetch call.

The change here is very minimal to use the init and url from the fetchParams as potentially returned by the pre middleware.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Current implementation will always pass the initial url and init object. However if a pre middleware changes returns an object whose `init` or `url` property refer to a different url string or object, any following post middleware wont have access to it. Effectively providing the post middleware with a completely different request information then what was actually used to make the fetch call.
@FabianSellmann
Copy link
Contributor Author

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)
Tagging you guys here, will clone the repo locally and build and update as suggested in the PR template.
Can this be a patch or should I target a different branch?

@FabianSellmann FabianSellmann marked this pull request as ready for review June 8, 2021 07:39
Copy link
Contributor

@amakhrov amakhrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good to me, nice catch!

@macjohnny macjohnny merged commit 32c1e92 into OpenAPITools:master Jun 9, 2021
@macjohnny macjohnny added this to the 5.2.0 milestone Jun 9, 2021
@smedina01
Copy link

smedina01 commented Jun 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants