Skip to content

[go-server] fix addResponseHeaders tpl option typo #9814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mgoltzsche
Copy link
Contributor

@mgoltzsche mgoltzsche commented Jun 20, 2021

According to the documentation the go-server generator should support an addResponseHeaders option but a template uses an addResponseHeader option in some places which this PR fixes.

Closes #9795

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

According to the [documentation](https://openapi-generator.tech/docs/generators/go-server) the go-server generator should support an `addResponseHeaders` option but a template uses an `addResponseHeader` option in some places which this PR fixes.

Closes OpenAPITools#9795

Signed-off-by: Max Goltzsche <[email protected]>
@wing328 wing328 added this to the 5.2.0 milestone Jun 21, 2021
@wing328
Copy link
Member

wing328 commented Jun 21, 2021

Good catch. The fix looks good to me 👍

Thanks for the contribution.

@wing328 wing328 merged commit 2e85ccd into OpenAPITools:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] go-server doesn't honour the provided headers within EncodeJSONResponse
2 participants