Skip to content

[Java] [Native] Remove trailing slashes from the baseUri #9837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gama11
Copy link
Contributor

@Gama11 Gama11 commented Jun 24, 2021

Otherwise, you can end up with double slashes, e.g. https://example.com//path. Some severs are actually ok with that, but you can't rely on it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

Otherwise, you can end up with double slashes, e.g. https://example.com//path. Some severs are actually ok with that, but you can't rely on it.
@wing328
Copy link
Member

wing328 commented Jul 4, 2021

Thanks for the PR. Is this similar to #7940?

Which OpenAPI Generator version are you using?

@Gama11
Copy link
Contributor Author

Gama11 commented Jul 4, 2021

I'm using version 5.1.1.

That PR does seem somewhat related, but it appears to only remove trailing slashes from the URLs declared within the "hardcoded" servers in the OpenAPI YML file. That doesn't help with the use case we have, where we set a custom baseUri (which may or may not have a traliling slash) via the ApiClient constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants