-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[Java][RestTemplate][WebClient] Templatized query params for metrics and evicts oom #9871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][RestTemplate][WebClient] Templatized query params for metrics and evicts oom #9871
Conversation
Update to 4.2.3
Hi I see the next error in continous-integration/appveyor/pr Stack Trace:
at Org.OpenAPITools.Api.PetApi.UpdatePetWithFormWithHttpInfoAsync(Int64 petId, String name, String status, CancellationToken cancellationToken) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Api\PetApi.cs:line 1680
at Org.OpenAPITools.Api.PetApi.UpdatePetWithFormAsync(Int64 petId, String name, String status, CancellationToken cancellationToken) in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools\Api\PetApi.cs:line 1623
at Org.OpenAPITools.Test.Api.PetApiTestsV2.UpdatePetWithFormAsync_GivenExistentId_UpdatesTheFields() in C:\projects\openapi-generator\samples\client\petstore\csharp-netcore\OpenAPIClient-httpclient\src\Org.OpenAPITools.Test\Api\PetApiTestsV2.cs:line 442 but i have not changed anything related with csharp-netcore. thank you |
modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/ApiClient.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/ApiClient.mustache
Show resolved
Hide resolved
Hi @wing328 I don't understand why failed continuous-integration/appveyor/pr — AppVeyor build failed |
Appveyor failure not related to this change. |
Thank you and congratulations @jorgerod ! |
For both RestTemplate and WebClient java clients were not being query params
This causes uriTags to be created for each query parameter and could lead to an Out Of Memory.
This PR Resolves #7899 and extends the feature for RestTemplate.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x