Skip to content

Review and update all 3rd party libs used in F2.js #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
markhealey opened this issue Jun 6, 2013 · 8 comments
Closed
5 tasks done

Review and update all 3rd party libs used in F2.js #106

markhealey opened this issue Jun 6, 2013 · 8 comments
Milestone

Comments

@markhealey
Copy link
Member

Track third party libs used in F2 for updates, bug fixes, and security patches. Schedule the rollout of those updates into releases of F2.

  • bootstrap-modal.js
  • EventEmitter2
  • jQuery
  • RequireJS
  • easyXDM
@markhealey
Copy link
Member Author

Current versions in use:

  • bootstrap-modal.js 2.2.2
  • hij1nx EventEmitter2 (no versioning on this lib but F2's copy is from mid-2012)
  • jQuery JavaScript Library 1.8.3
  • RequireJS 2.1.4
  • easyXDM 2.4.15

No changes needed for:

  • json2

All the 3rd party source is found here.

@markhealey markhealey mentioned this issue Oct 15, 2013
30 tasks
@markhealey
Copy link
Member Author

Also looking at updating devDependencies in package.json.

https://gemnasium.com/OpenF2/F2

@markhealey
Copy link
Member Author

Regarding f6ca413, the update to 2.1.9 introduced multipleDefine errors in the Jasmine tests. Here's the diff between 2.1.4 and 2.1.9. All of the specs still pass.

Update: This is an error specifically related to using Dojo's loader in the AMD-specific test index-amd.html page. The only reason the error occurs is because we're force-reloading, or force-requiring, F2.js for each test. I am going to replace Dojo with RequireJS for the purposes of the tests.

@markhealey
Copy link
Member Author

I've replaced Dojo with RequireJS for the AMD Jasmine unit tests in 44de277. It has fixed the multipleDefine console errors.

@markhealey
Copy link
Member Author

Upgraded easyXDM to latest (2.4.19) which includes the latest security updates in 73529b6 for #142.

@markhealey
Copy link
Member Author

Updated bootstrap-modal earlier today for #142

@markhealey
Copy link
Member Author

jQuery updated in 4435a91. All 3rd party libs have been updated.

@markhealey
Copy link
Member Author

Also see 613f3b3 for more deps updated in 1.4.0 release, #142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant