-
Notifications
You must be signed in to change notification settings - Fork 61
App Placeholders #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Placeholders #169
Conversation
* fixed duplicate sourcemap call in Gruntfile * added F2.loadPlaceholders * fixed comments surrounding the CSS classes that are applied to apps when rendering * fixed a bug where the wrong CSS classes were being applied with the default AppHandlers * added logic to allow placeholder apps to bypass AppHandlers * added autoload logic for placeholders * added a basic container to demonstrate placeholder functionality * added unit tests surrounding placeholders * fixed a bug in the example containers where the proper CSS classes were not being applied
* fixed failing unit test that appears unrelated to these updates * removed debug logging
…olders Conflicts: F2.latest.js sdk/f2.debug.js sdk/f2.min.js sdk/f2.min.map sdk/f2.no-third-party.js
Could you explain what is meant by placeholders? I took a look at the pull request but couldn't understand the intent of the code. |
Check out the basic example container for example usage. Basically, F2 is just going to search the DOM for elements with |
I get it now. Thanks for the explanation. I think of this as a declarative style vs. the older imperative style. |
- removed all dependency on jQuery except for DOM ready - expanded autoload functionality to classes and attributes - added additional unit tests
Porting a proposed v2 enhancement to v1. Here are the updates so far:
when rendering
default AppHandlers
were not being applied
F2.removeApp()
that appears unrelated to these updatesRemaining To Do: See #142
data-f2-appid
attribute. Should the search be narrowed to elements with an "autoload" attribute?appId
,manifestUrl
andcontext
properties of theAppConfig
are pulled from the placeholders. Should more properties be pulled? See Autoload placeholder configuration attributes #187