Skip to content

App Placeholders #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 8, 2014
Merged

App Placeholders #169

merged 8 commits into from
Jul 8, 2014

Conversation

brianbaker
Copy link
Member

Porting a proposed v2 enhancement to v1. Here are the updates so far:

  • fixed duplicate sourcemap call in Gruntfile
  • added F2.loadPlaceholders
  • fixed comments surrounding the CSS classes that are applied to apps
    when rendering
  • fixed a bug where the wrong CSS classes were being applied with the
    default AppHandlers
  • added logic to allow placeholder apps to bypass AppHandlers
  • added autoload logic for placeholders
  • added a basic container to demonstrate placeholder functionality
  • added unit tests surrounding placeholders
  • fixed a bug in the example containers where the proper CSS classes
    were not being applied
  • fixed failing unit test related to F2.removeApp() that appears unrelated to these updates

Remaining To Do: See #142

brianbaker and others added 4 commits April 29, 2014 16:27
* fixed duplicate sourcemap call in Gruntfile
* added F2.loadPlaceholders
* fixed comments surrounding the CSS classes that are applied to apps
when rendering
* fixed a bug where the wrong CSS classes were being applied with the
default AppHandlers
* added logic to allow placeholder apps to bypass AppHandlers
* added autoload logic for placeholders
* added a basic container to demonstrate placeholder functionality
* added unit tests surrounding placeholders
* fixed a bug in the example containers where the proper CSS classes
were not being applied
* fixed failing unit test that appears unrelated to these updates
* removed debug logging
…olders

Conflicts:
	F2.latest.js
	sdk/f2.debug.js
	sdk/f2.min.js
	sdk/f2.min.map
	sdk/f2.no-third-party.js
@ilinkuo
Copy link

ilinkuo commented Apr 30, 2014

Could you explain what is meant by placeholders? I took a look at the pull request but couldn't understand the intent of the code.

@brianbaker
Copy link
Member Author

Check out the basic example container for example usage. Basically, F2 is just going to search the DOM for elements with data-f2-appid and grab the attributes of that element to build up an AppConfig and then register the app. The app will be rendered inside of that "placeholder" element.

@ilinkuo
Copy link

ilinkuo commented May 1, 2014

I get it now. Thanks for the explanation. I think of this as a declarative style vs. the older imperative style.

brianbaker added 4 commits May 6, 2014 14:07
- removed all dependency on jQuery except for DOM ready
- expanded autoload functionality to classes and attributes
- added additional unit tests
@markhealey markhealey mentioned this pull request May 12, 2014
30 tasks
markhealey added a commit that referenced this pull request Jul 8, 2014
@markhealey markhealey merged commit 1f535ad into 1.4-wip Jul 8, 2014
@markhealey markhealey added this to the 1.4.0 milestone Nov 18, 2014
markhealey pushed a commit that referenced this pull request Nov 19, 2014
@markhealey markhealey deleted the app-placeholders branch November 25, 2014 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants