Skip to content

Chore: Add Captainhook & PHPCS to composer require-dev and sample captainhook config #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Chore: Add Captainhook & PHPCS to composer require-dev and sample captainhook config #1264

wants to merge 2 commits into from

Conversation

kkrieger85
Copy link
Contributor

Add captainhook and PHPCS to composer require-dev section
Add sample captainhook config

closes #1120 (duplication)
refs #947 #982

Please consider, that commit hooks are disabled in captainhook.json

You could test it by installing packages with composer and using the PHPCS Rule with using the command in captainhook.json

@kkrieger85 kkrieger85 added hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted labels Oct 18, 2020
@kkrieger85 kkrieger85 changed the title 947 982 1120 captainhook initial Chore: Add Captainhook & PHPCS to composer require-dev and sample captainhook config Oct 18, 2020
@github-actions github-actions bot added the composer Relates to composer.json label Oct 18, 2020
@tmotyl
Copy link
Contributor

tmotyl commented Aug 6, 2021

I would love to have php-cs fixer in place.
This change however is missing few pieces:

  1. php-cs-fixer configuration file (lets start with config which is not making too much changes in the codebase - and add new rules later on
  2. github action to validate codestyle on PR
  3. use friendsofphp/php-cs-fixer v3 instead of v2

@kkrieger85
Copy link
Contributor Author

Feel free to update my PR

@kkrieger85 kkrieger85 closed this Feb 18, 2022
@sreichel sreichel reopened this Aug 10, 2022
@sreichel
Copy link
Contributor

Seems related to #2400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Relates to composer.json environment hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants