fix: TransactionRequest TryFrom fn #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limyeechern
requested review from
collins-w,
d-carmo,
dylankilkenny,
nahimterrazas,
zeljkoX,
shahnami,
tirumerla and
LuisUrrutia
as code owners
✅ Deploy Preview for openzeppelin-relayer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
All contributors have signed the CLA ✍️ ✅ |
|
I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement |
zeljkoX
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
hi @limyeechern
Thank you for improving the code and for your contribution!
LuisUrrutia
changed the title
|
CLA assistant is failing, we have fix for this in pipeline |
shahnami
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to decode the calldata using hex::decode for TransactionInput, otherwise estimate_gas that converts EvmTransactionData to TransactionRequest will fail
Testing Process
Checklist