Skip to content

[Feature]: Allow setting msg::sender in unit tests #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexfertel opened this issue Apr 3, 2024 · 2 comments · Fixed by #14
Closed

[Feature]: Allow setting msg::sender in unit tests #12

alexfertel opened this issue Apr 3, 2024 · 2 comments · Fixed by #14

Comments

@alexfertel
Copy link

No description provided.

@alexfertel alexfertel self-assigned this Apr 3, 2024
@alexfertel
Copy link
Author

A spike trying to get this to work resulted in these changes. In the end, it is impossible to set msg::sender right now since it is a global CachedOption private to the SDK, so we can't access it.

@0xNeshi
Copy link
Collaborator

0xNeshi commented Sep 17, 2024 •
edited
Loading

Maybe a wrapper around msg::sender similar to Solidity's Context would alleviate the issue?
If there were a pub trait IContext that was implemented for the Context contract (that other contracts inherit), then the trait can be mocked in tests (e.g. using mockall)

@qalisander qalisander changed the title Allow setting msg::sender in unit tests [Feature]: Allow setting msg::sender in motsu unit tests Oct 3, 2024
@qalisander qalisander changed the title [Feature]: Allow setting msg::sender in motsu unit tests [Feature]: Allow setting msg::sender in unit tests Oct 3, 2024
@qalisander qalisander mentioned this issue Nov 28, 2024
Merged
3 tasks
@ggonzalez94 ggonzalez94 transferred this issue from OpenZeppelin/rust-contracts-stylus Dec 17, 2024
@qalisander qalisander mentioned this issue Dec 19, 2024
Merged
3 tasks
@0xNeshi 0xNeshi mentioned this issue Jan 14, 2025
Closed
1 task
@github-project-automation github-project-automation bot moved this from Blocked to Done in Rust Contracts Stylus Feb 3, 2025
@0xNeshi 0xNeshi mentioned this issue Feb 11, 2025
Open
1 task
bidzyyys added a commit to OpenZeppelin/rust-contracts-stylus that referenced this issue Feb 11, 2025
@qalisander @bidzyyys @0xNeshi
ref(test): migrate unit tests to the new motsu layout (#423)
e735e3d 
This pr contains migration of unit test to the new layout of motsu unit
tests, that will be introduced in OpenZeppelin/stylus-test-helpers#8 and
OpenZeppelin/stylus-test-helpers#12

Resolves #470 

#### PR Checklist

- [x] Tests
- [ ] Documentation
- [ ] Changelog

---------

Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Nenad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Rust Contracts Stylus
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: unit test external call + msg::sender mocks OpenZeppelin/stylus-test-helpers
2 participants
@0xNeshi @alexfertel