chore: Update test dependencies in Python projects #18581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
added
the
DO NOT MERGE
pipenv upgrade --dev 'pytest>=8.4.0,<9'
Also: - uninstall unused mock and types-mock deps. - replace pytest-lazy-fixture with pytest-lazy-fixtures.
pipenv upgrade --dev 'decoy>=2.2.0,<3' 'pytest-asyncio>=0.23.0,<2' 'pytest>=8,<9' 'hypothesis>=6.96.1,<7'
Resolved in Decoy 2.2.0.
pytest-lazy-fixtures was erroring here because of something having to do with old_settings being scope=session, whereas all of the things it was built on (v1_config, v2_config, etc.) were scope=function. I don't fully understand this, but moving everything to scope=function fixes it and seems strictly safer (more isolated), so let's just do that.
Marks have apparently never had any effect when applied to fixtures.
Also delete graphviz, which has not been used here since PR #14544.
pytest 7 was silently skipping these, and pytest 8 made them an error. I don't know for how long they were being skipped. Fortunately, they all still pass when we reenable them using asyncio_mode=auto, which follows the pytest-aiohttp docs.
This was added deliberately to match robot-server, but I'm not sure why? Neither server-utils nor any of its dependencies use it.
SyntaxColoring
force-pushed
the
python_test_dep_updates
branch
from
beae8e3 to
d5338b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18581 +/- ##
==========================================
- Coverage 23.77% 22.57% -1.21%
==========================================
Files 3233 3233
Lines 279281 279670 +389
Branches 27012 27025 +13
==========================================
- Hits 66413 63144 -3269
- Misses 212845 216504 +3659
+ Partials 23 22 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This does updates and light cleanup on most Python projects' test dependencies.
There's no particular urgency to this. Just in case this breaks something, I think we should hold off until v8.5.0 has been released and the dust has settled on mergebacks, and then merge this into
edge.Test Plan and Hands on Testing
Just make sure CI keeps passing on everything.
Changelog
Notable changes:
@pytest.marks that were applied to fixtures, which doesn't do anything.async deftests that were not being run (!) because our asyncio plugin was not configured. They are running now.Review requests
None in particular.
Risk assessment
Low. Changes are limited to dev dependencies.