Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Article Landmarks ARIA (French version) #634

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Update] Article Landmarks ARIA (French version) #634

wants to merge 3 commits into from

Conversation

isabellechanclou
Copy link
Member

Pour relecture...

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for a11y-guidelines ready!

Name Link
🔨 Latest commit 567c07e
🔍 Latest deploy log https://app.netlify.com/sites/a11y-guidelines/deploys/67bdd2030c484b00081a281f
😎 Deploy Preview https://deploy-preview-634--a11y-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@isabellechanclou isabellechanclou self-assigned this Jan 30, 2025
@isabellechanclou isabellechanclou force-pushed the ic_update_landmarks_ARIA_article branch from 9ae5afd to 89ac80e Compare January 30, 2025 13:42
MewenLeHo
MewenLeHo requested changes Jan 30, 2025
View reviewed changes
src/fr/articles/landmarks-aria/index.njk Outdated
<li>Pour identifier le formulaire de recherche dans le site, on utilisera seul le <code>role=search</code> <abbr>ARIA</abbr>.</li>
<li>Si besoin, le contenu annexe au contenu principal de la page (information complémentaire, publicité…) doit être identifié en utilisant la balise <code>aside</code> ou le <code>role=complementary</code>.</li>
<p>Pour ajouter de la sémantique HTML au contenu d'une page, 2 possibilités :</p>
<ol>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be a list, especially an ordered one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a list ?

Copy link
Member Author

@isabellechanclou isabellechanclou Feb 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We said OK for an unordered list (ul)

src/fr/articles/landmarks-aria/index.njk Outdated
Ces balises doivent être utilisées seules, sans les rôles <abbr>ARIA</abbr> correspondants, car leur support est bon dans la grande majorité des navigateurs et des aides techniques.</p>

<p>Exemple&nbsp;:</p>
<p class="bg-primary d-inline-block p-2 mb-0 font-weight-bold">HTML</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for it, the tag 'HTML' is added automatically in the <pre><code> component.

Copy link
Member Author

@isabellechanclou isabellechanclou Jan 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add that line because otherwise the tag 'HTML' doesn't show...
OK, I had to refresh after hot reload to have the correct display without that extra line.

src/fr/articles/landmarks-aria/index.njk Outdated
<p></p><u>Pour une page qui n'est <em>pas en HTML5</em></u> : ajouter des <em>régions (<i lang="en">landmarks</i>) <abbr>ARIA</abbr></em></p>

<p>Exemple&nbsp;:</p>
<p class="bg-primary d-inline-block p-2 mb-0 font-weight-bold">HTML</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for it, the tag 'HTML' is added automatically in the <pre><code> component.

Copy link
Member Author

@isabellechanclou isabellechanclou Jan 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add that line because otherwise the tag 'HTML' doesn't show...
OK, I had to refresh after hot reload to have the correct display without that extra line.

src/fr/articles/landmarks-aria/index.njk Outdated
<h3 class="mt-4">Ressources</h3>
<ul>
<li>https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/</li>
</ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing blank line at the end of the file.

src/fr/articles/landmarks-aria/index.njk Outdated

<h3 class="mt-4">Ressources</h3>
<ul>
<li>https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/</li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/</li>
<li><a href="https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/" hreflang="en">Landmark Regions specification</a></li>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure !!!

src/fr/articles/landmarks-aria/index.njk Outdated
</li>

<li>
<p></p><u>Pour une page qui n'est <em>pas en HTML5</em></u> : ajouter des <em>régions (<i lang="en">landmarks</i>) <abbr>ARIA</abbr></em></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To stay consistent with the reste of the website, underlined text is for links only.

src/fr/articles/landmarks-aria/index.njk Outdated
</li>

<li>
<p></p><u>Pour une page qui n'est <em>pas en HTML5</em></u> : ajouter des <em>régions (<i lang="en">landmarks</i>) <abbr>ARIA</abbr></em></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p></p><u>Pour une page qui n'est <em>pas en HTML5</em></u> : ajouter des <em>régions (<i lang="en">landmarks</i>) <abbr>ARIA</abbr></em></p>
<p><u>Pour une page qui n'est <em>pas en HTML5</em></u> : ajouter des <em>régions (<i lang="en">landmarks</i>) <abbr>ARIA</abbr></em></p>

src/fr/articles/landmarks-aria/index.njk Outdated
</tr>
<tr>
<td><code>form</code></td>
<td><code>role="form"</code> s'il y a un nom accessible donné par aria-labelledby, aria-label ou title</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td><code>role="form"</code> s'il y a un nom accessible donné par aria-labelledby, aria-label ou title</td>
<td><code>role="form"</code> s'il y a un nom accessible donné par <code>aria-labelledby</code>, <code>aria-label</code> ou <code>title</code></td>

src/fr/articles/landmarks-aria/index.njk Outdated
</tr>
<tr>
<td><code>section</code></td>
<td><code>role="region"</code> s'il y a un nom accessible donné par aria-labelledby, aria-label ou title</code> ou <code>aria-label</code></td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td><code>role="region"</code> s'il y a un nom accessible donné par aria-labelledby, aria-label ou title</code> ou <code>aria-label</code></td>
<td><code>role="region"</code> s'il y a un nom accessible donné par <code>aria-labelledby</code>, <code>aria-label</code> ou <code>title</code></td>

src/fr/articles/landmarks-aria/index.njk Outdated
<li>La balise <code>aside</code> ou l'attribut <code>role="complementary"</code> est à utiliser pour identifier du contenu annexe au contenu principal de la page (information complémentaire, publicité…).</li>
<li>La balise <code>footer</code> ou l'attribut <code>role="contentinfo"</code> permet d’identifier le pied de page. A n'utiliser qu'une seule fois dans la page.</li>
</ul>
<p>Ces 4 balises ou attributs de région (<i lang="en">landmarks</i>) <abbr>ARIA</abbr> doivent être placés directement dans une balise <code>body</code> (et pas dans une autre balise elle-même imbriquée dans la balise <code>body</code>).</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to add some space here in order to make it easier to understand that this sentence is linked to previous list and not the next one.

@isabellechanclou isabellechanclou force-pushed the ic_update_landmarks_ARIA_article branch from 89ac80e to d30a4f4 Compare February 24, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MewenLeHo MewenLeHo MewenLeHo requested changes

@Aniort Aniort Awaiting requested review from Aniort

Requested changes must be addressed to merge this pull request.

Assignees

@isabellechanclou isabellechanclou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isabellechanclou @MewenLeHo