-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Feature: add limit option to setvalues #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Progi1984
merged 14 commits into
PHPOffice:master
from
moghwan:feat/add-limit-to-setvalues
Feb 13, 2025
Merged
Feature: add limit option to setvalues #2640
Progi1984
merged 14 commits into
PHPOffice:master
from
moghwan:feat/add-limit-to-setvalues
Feb 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
@moghwan Hi, could you add Unit Tests, please ? |
sure thing! |
done |
…o feat/add-limit-to-setvalues
Progi1984
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moghwan Could you rebase the PR and update the changelog 1.4.0 ?
After that, it will be a merge.
branch & doc change updated |
@moghwan Thank you for your contribution 🥳 |
with pleasure 😁 |
MichaelPFrey
pushed a commit
to MichaelPFrey/PHPWord
that referenced
this pull request
Feb 15, 2025
* adding limit option to setValues for multiple values * add parameter type * Update 2.0.0.md * add more replacement for testSetValues * testSetValues with different limit values * testSetValues with a zero replacement * Update 1.3.0.md * improve tests with variables count check to ensure number of occurrences replaced * Update 1.4.0.md * Update 1.3.0.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a limit parameter to the setValues function, which itself is uses within with setValue. This will help to avoid to minimize written if the limit is needed for a bulk search&replace operation.
example:
Checklist: