perf: Redo benchmarks #4654
Merged
perf: Redo benchmarks #4654
+87
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haven't touched these in years and wanted to check that the parser changes don't have any perf impact. Running something like `cargo bench --bench=bench -- prql_to_pl --quick` will quickly time how long it takes to parse each of our canonical queries. One tradeoff is that _changing_ our canonical queries means that the benchmarks don't compare through time. So possibly we should have a couple we try and almost never change...
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't touched these in years and wanted to check that the parser changes don't have any perf impact.
Running something like
cargo bench --bench=bench -- prql_to_pl --quickwill quickly time how long it takes to parse each of our canonical queries.One tradeoff is that changing our canonical queries means that the benchmarks don't compare through time. So possibly we should have a couple we try and almost never change...