Skip to content

Upgrade to AWS SDK v4 #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Upgrade to AWS SDK v4 #2816

wants to merge 28 commits into from

Conversation

lailabougria
Copy link
Contributor

@lailabougria lailabougria commented Apr 29, 2025

This pull request is currently blocked due to a policy deserialization issue in the AWS SDK that should be fixed soon

What is left to do:

  • Update to the SDK with the bug fix
  • Figure out the clock skew code and whether it requires caching. It would also be possible to switch to something like
var serviceOperationEndpoint = sqsClient.Config.DetermineServiceOperationEndpoint(new ServiceOperationEndpointParameters(new GetCallerIdentityRequest()));
                var clockSkew = CorrectClockSkew.GetClockCorrectionForEndpoint(serviceOperationEndpoint.URL);
  • Do further checks on the code path to figure out whether all the collection types have appropriate null checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants