Skip to content

Plot aggregated QC measures and CBF across dataset #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented May 21, 2025

Closes #285.

Changes proposed in this pull request

  • Create workflow to collect QC json files from ASLPrep derivatives and plot the distribution of each QC metric in a separate figure.

@tsalo tsalo added the enhancement New feature or request label May 21, 2025
@tsalo tsalo marked this pull request as draft May 21, 2025 20:18
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 243 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (1729618) to head (09890f9).

Files with missing lines Patch % Lines
aslprep/interfaces/group.py 0.00% 127 Missing ⚠️
aslprep/cli/aggregate_qc.py 0.00% 116 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   83.24%   78.91%   -4.33%     
==========================================
  Files          38       39       +1     
  Lines        4101     4326     +225     
==========================================
  Hits         3414     3414              
- Misses        687      912     +225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo
Copy link
Member Author

tsalo commented May 24, 2025

I think the plotting and concatenation interfaces are solid, but the data collection and workflow still need to be fixed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate figures/report for the aggregated QC metrics from the combine-qc command
2 participants