Skip to content

Implement general kinetic model with weighted average-based priors #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jun 2, 2025

Builds on #545.

Changes proposed in this pull request

  • For multi-PLD PCASL data, calculate CBF and ATT using the weighted average approach, then pass those arrays into the GKM method as initial estimates for those variables.

@tsalo tsalo added enhancement New feature or request breaking-change PRs that change results or interfaces. labels Jun 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.33%. Comparing base (32cc579) to head (811d291).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
aslprep/utils/cbf.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   76.19%   76.33%   +0.14%     
==========================================
  Files          38       38              
  Lines        4382     4404      +22     
==========================================
+ Hits         3339     3362      +23     
+ Misses       1043     1042       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo
Copy link
Member Author

tsalo commented Jun 2, 2025

Using the weighted-average CBF and ATT as priors doesn't seem to help in our test dataset.
image

@tsalo tsalo marked this pull request as draft June 2, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants