New tiling init map #350
Merged
New tiling init map #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianbean
approved these changes
Sep 21, 2021
enadeau
added a commit
that referenced
this pull request
Sep 22, 2021
* fix test that use expand_verified * Make the forward tiling map a class * add documentation * add a map_row and map_column method * update row map * fixing stuff I'm not sure I understand * remove dead stuff * good way to get preimage for grinding counter * Revert "fixing stuff I'm not sure I understand" This reverts commit 5688454. * remove some sum/skew import that no longer make sense * add remove requirements on tiling * fix a sort assumption not existing function * fix assumption map update * New tiling init map (#350) * Make the forward tiling map a class * add documentation * add a map_row and map_column method * remove print * cleaning after discussion with Christian * import sorting
enadeau
added a commit
that referenced
this pull request
Sep 22, 2021
* fix test that use expand_verified * Make the forward tiling map a class * add documentation * add a map_row and map_column method * update row map * fixing stuff I'm not sure I understand * remove dead stuff * good way to get preimage for grinding counter * Revert "fixing stuff I'm not sure I understand" This reverts commit 5688454. * remove some sum/skew import that no longer make sense * add remove requirements on tiling * fix a sort assumption not existing function * fix assumption map update * New tiling init map (#350) * Make the forward tiling map a class * add documentation * add a map_row and map_column method * remove print * cleaning after discussion with Christian * import sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably consider moving the map class to another file. I think we
could probably use the same class for the map between tiling and assumption.