Alt contains #526
Open
Alt contains #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the GriddedPerm containment logic to improve performance by caching values and reordering checks. Key changes include:
- Caching the length of the pattern in init and using it in len.
- Refactoring contains to delegate to a new contains_patt method.
- Introducing contains_patt_proper and contains_pos methods for optimized checks.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tilings/griddedperm.py | Optimized containment logic with caching and refactored methods. |
| CHANGELOG.md | Updated changelog to reflect new performance improvements. |
| # positions of self could potentially contain the positions of patt, | ||
| # and only if so does it check if there is an occurrence of patt in | ||
| # self. We also cached GriddedPerm.len at this time. | ||
| return self.contains_pos(patt) and any(True for _ in patt.occurrences_in(self)) |
There was a problem hiding this comment.
[nitpick] The generator expression 'any(True for _ in ...)' is redundant; consider using 'any(patt.occurrences_in(self))' directly for clarity and efficiency.
Suggested change
| return self.contains_pos(patt) and any(True for _ in patt.occurrences_in(self)) | |
| return self.contains_pos(patt) and any(patt.occurrences_in(self)) |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This doesn't work as some of the objects yielded have a False boolean.
christianbean
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.