Skip to content

Add Ubisoft connect (Linux Proton) support #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 29, 2023
Merged

Conversation

Ofacy
Copy link
Contributor

@Ofacy Ofacy commented May 26, 2023

This code might not look good, but it works on my machine hey.
I just did the bare minimum to get it working on my steam deck, just wanted to share this.

Quick note about that commit, this is my first time reading and writing rust, this code might not look good or even work on your machine, but I managed to get it working on my steam deck and I wanted to share this with anyone who wants it, so here is my code.

@Ofacy Ofacy changed the title Added Ubisoft connect (Linux Proton) support Add Ubisoft connect (Linux Proton) support May 26, 2023
@Ofacy
Copy link
Contributor Author

Ofacy commented May 26, 2023

This would resolve #255, #215 and #51. Allowing direct use of Ubisoft connect instead of using third party "launcher" steps.

@PhilipK
Copy link
Owner

PhilipK commented May 27, 2023

This is seriously awesome, thanks! I will look through the code in detail tonight, but great they you got it working

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@PhilipK
Copy link
Owner

PhilipK commented May 28, 2023

For being the first time you have done any Rust I am very impressed.

The errors you are seeing in the pipeline is because I have configured clippy (linter) to disallow any operation that would possibly crash Boilr. I have made the changes locally that would fix this, I guess the best way of getting them into this pull request is by using the suggestions feature.

Copy link
Owner

@PhilipK PhilipK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here suggestions that should fix the possible crashes

Ofacy and others added 2 commits May 28, 2023 15:30
Co-authored-by: Philip Kristoffersen <[email protected]>
Co-authored-by: Philip Kristoffersen <[email protected]>
@Ofacy
Copy link
Contributor Author

Ofacy commented May 28, 2023

There it should now successfully build for linux too, hope this works. I'll remind myself to take my time next time I wanna commit something instead of pushing 3 commits out of panic.

@PhilipK
Copy link
Owner

PhilipK commented May 28, 2023

The last problem for window just seems to be a function that needs to be included in that built. Do you have access to a windows machine? Otherwise i can find the fix tonight

@Ofacy
Copy link
Contributor Author

Ofacy commented May 28, 2023

There this should fix the error, didn't have much time, we might want to make those includes "unix only" to remove the last warnings.

@PhilipK PhilipK merged commit c092ffb into PhilipK:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants