Add request, response log for the Portkey PII plugin to the main requ… #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisargD
reviewed
May 5, 2025
| @@ -2,7 +2,7 @@ import { getRuntimeKey } from 'hono/adapter'; | |||
| import { post, postWithCloudflareServiceBinding } from '../utils'; | |||
| import { PluginParameters } from '../types'; | |||
|
|
|||
| export const BASE_URL = 'https://api.portkey.ai/v1/execute-guardrails'; | |||
| export const BASE_URL = 'https://api.portkeydev.com/v1/execute-guardrails'; | |||
There was a problem hiding this comment.
Can you please revert the URL?
VisargD
reviewed
May 5, 2025
| let error: any = null; | ||
|
|
||
| try { | ||
| if (getRuntimeKey() === 'workerd' && env.portkeyGuardrails && 0) { |
There was a problem hiding this comment.
Can you please remove the dummy && 0 check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Add request, response log for the Portkey PII plugin to the main request trace
🔄 What Changed
🔍 Impact of the Change
📁 Total Files Changed
🧪 Test Added
N/A - No tests were added in this PR
🔒 Security Vulnerabilities
No security vulnerabilities were introduced. The PR improves security observability.
Quality Recommendations
Add proper error handling for the case when both the Cloudflare service binding and regular post request fail
Consider adding type safety for the error object in the catch block
Add validation for the response data before processing it
Consider adding unit tests for the new logging functionality