feat: add optional nulls=stripped parameter for mediatypes applicatio… #2894
Conversation
src/PostgREST/MediaType.hs
Outdated
| MTApplicationJSON == MTApplicationJSON = True | ||
| MTArrayJSONStrip == MTArrayJSONStrip = True | ||
| MTSingularJSONStrip == MTSingularJSONStrip = True | ||
| MTSingularJSON == MTSingularJSON = True | ||
| MTGeoJSON == MTGeoJSON = True | ||
| MTTextCSV == MTTextCSV = True | ||
| MTTextPlain == MTTextPlain = True | ||
| MTTextXML == MTTextXML = True | ||
| MTOpenAPI == MTOpenAPI = True | ||
| MTUrlEncoded == MTUrlEncoded = True | ||
| MTOctetStream == MTOctetStream = True | ||
| MTAny == MTAny = True | ||
| MTOther x == MTOther y = x == y | ||
| MTPlan{} == MTPlan{} = True | ||
| _ == _ = False |
There was a problem hiding this comment.
I realize this is quite ugly. I think the whole media type handling could be refactored to use https://hackage.haskell.org/package/http-media-0.8.0.0/docs/Network-HTTP-Media.html.
(This might be complex, so not a requirement for this PR)
Then we could remove this part.
There was a problem hiding this comment.
Perhaps, maybe we should move this refactoring to a new separate issue to work on?
There was a problem hiding this comment.
@taimoorzaeem Could you open that one 🙏 ? I'll tag it as "refactoring".
|
@taimoorzaeem The end result looks good 👍. But the code needs some refactoring. I've added some comments. |
…n/vnd.pgrst.array+json and application/vnd.pgrst.object+json
|
@taimoorzaeem Just found a bug here. So currently we accept doing: But the array fails on It always requires the |
|
@steve-chavez Oh, I can't believe how I missed this. It's an easy fix, let me send a PR. |
…n/vnd.pgrst.array+json and application/vnd.pgrst.object+json
Fixes issue #1601.
@steve-chavez The codecov is not working for me yet. Let me know if any warnings show up. Also, I am not exactly sure what combinations of testcases need to be written for this feature so please let me know if I need to add more.