-
Notifications
You must be signed in to change notification settings - Fork 933
SVCB: allow parsing keys in generic format without value #15603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 15293710190Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There's still a parsing issue that I need to debug. |
Pushed some additional test cases and a fix for that. |
@miodvallat could you rereview? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looking good.
Short description
To avoid other issues, increase strictness of value checks for known keys, regardless if they are in generic or canonical format.
Also add a test for key00NNN (= leading zeroes).
#15479
Checklist
I have: