Skip to content

SVCB: allow parsing keys in generic format without value #15603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zeha
Copy link
Collaborator

@zeha zeha commented May 27, 2025

Short description

To avoid other issues, increase strictness of value checks for known keys, regardless if they are in generic or canonical format.

Also add a test for key00NNN (= leading zeroes).

#15479

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented May 27, 2025

Pull Request Test Coverage Report for Build 15293710190

Details

  • 73 of 75 (97.33%) changed or added relevant lines in 3 files are covered.
  • 52 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.005%) to 63.701%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/rcpgenerator.cc 28 30 93.33%
Files with Coverage Reduction New Missed Lines %
ext/json11/json11.cpp 1 64.68%
pdns/validate.cc 1 68.24%
modules/lmdbbackend/lmdbbackend.cc 2 74.66%
pdns/rcpgenerator.cc 2 91.01%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/recursordist/syncres.cc 2 80.26%
pdns/sstuff.hh 2 57.5%
pdns/dnsdistdist/dnsdist-carbon.cc 3 61.8%
pdns/packethandler.cc 3 72.82%
pdns/recursordist/rec-main.cc 3 62.14%
Totals Coverage Status
Change from base Build 15271100803: 0.005%
Covered Lines: 130711
Relevant Lines: 170330

💛 - Coveralls

@zeha zeha marked this pull request as ready for review May 27, 2025 21:05
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeha zeha marked this pull request as draft May 28, 2025 06:54
@zeha
Copy link
Collaborator Author

zeha commented May 28, 2025

There's still a parsing issue that I need to debug.

@zeha
Copy link
Collaborator Author

zeha commented May 28, 2025

There's still a parsing issue that I need to debug.

Pushed some additional test cases and a fix for that.

@zeha zeha marked this pull request as ready for review May 28, 2025 07:05
@zeha zeha requested a review from miodvallat May 28, 2025 07:05
@zeha
Copy link
Collaborator Author

zeha commented Jun 10, 2025

@miodvallat could you rereview?

@zeha zeha requested a review from Habbie June 10, 2025 17:16
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants