Skip to content

Change order for winps-adapter to prefer Windows modules first, add warning when resource not found #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Apr 25, 2025

PR Summary

The WinPS adapter was previously appending the WinPS module path, but instead should be prepending so it gets used first
Also add a warning when using winps adapter and resource is not found as resource must be installed for AllUsers

@SteveL-MSFT SteveL-MSFT changed the title Change order for winps-adapter to prefer Windows modules first Change order for winps-adapter to prefer Windows modules first, add warning when resource not found Apr 26, 2025
@SteveL-MSFT SteveL-MSFT marked this pull request as ready for review April 26, 2025 00:12
Copy link
Collaborator

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Apr 28, 2025
Merged via the queue into PowerShell:main with commit 59cd4a7 Apr 28, 2025
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the psdsc-winps branch April 28, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants