feat(sekolahmu): add new presence #9536
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vin(cent) <[email protected]>
back then i deleted my repository (sekolahmu-premid) since i forgot to fork it, so now i just copy-paste it from my code editor Signed-off-by: vin(cent) <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: vin(cent) <[email protected]>
Signed-off-by: vin(cent) <[email protected]>
Signed-off-by: vin(cent) <[email protected]>
theusaf
requested changes
May 5, 2025
websites/S/sekolahmu/metadata.json
Outdated
Comment on lines
11
to
12
| "en": "Unofficial Discord presence of Sekolahmu LMS", | ||
| "id": "Unofficial status Discord buat LMS Sekolahmu" |
There was a problem hiding this comment.
Use the service's official description instead
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: vin(cent) <[email protected]>
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: vin(cent) <[email protected]>
… mandatory homework (they're using 'Kuis' instead of 'Tugas')
|
Done, thanks! |
theusaf
requested changes
May 5, 2025
|
Oh sorry! Ill resolve that later |
|
Done btw |
asesmenName: assessmentName Signed-off-by: vin(cent) <[email protected]>
|
?? |
theusaf
previously approved these changes
May 8, 2025
Bas950
requested changes
May 9, 2025
Co-authored-by: Bas van Zanten <[email protected]> Signed-off-by: vin(cent) <[email protected]>
auto-merge was automatically disabled
May 9, 2025 09:08
Head branch was pushed to by a user without write access
|
👍 |
|
i realized, the description is too short now. I want to change it |
Signed-off-by: vin(cent) <[email protected]>
auto-merge was automatically disabled
May 10, 2025 10:20
Head branch was pushed to by a user without write access
|
looks good now 👍 |
theusaf
requested changes
May 11, 2025
Co-authored-by: Daniel Lau <[email protected]> Signed-off-by: vin(cent) <[email protected]>
theusaf
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected