20200602 type hints part1 #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These temporary changes are needed in order to decouple adding typehints in separate PR's to a completely clean typehint checked system. It is not possible to have small independant commits and exhaustive typehint checking over the entire package.
hjmjohnson
force-pushed
the
20200602-type-hints_part1
branch
from
6ec00d3 to
b3cb4f9
Compare
1 task
|
@Nic-Ma @wyli This is on the critical path for breaking apart the larger PR. Every other PR will depend upon this one being merged first. The disabled tests here are only to allow PR's to be made that do not violate the (previous unchecked) typehint consistencies. I would appreciate if this could be evaluated right away to that other PR's can be made more cleanly. |
wyli
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #476
Description
Smaller PR for review of initial pre-amble for adding type hinting
Status
Ready
Types of changes