Typehinting bools #522
Merged
Typehinting bools #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
reviewed
Jun 9, 2020
| @@ -33,11 +33,11 @@ class DataLoader(torch.utils.data.DataLoader): | |||
| num_workers (int, optional): how many subprocesses to use for data | |||
| loading. ``0`` means that the data will be loaded in the main process. | |||
| (default: ``0``) | |||
| pin_memory (bool, optional): If ``True``, the data loader will copy Tensors | |||
| pin_memory: If ``True``, the data loader will copy Tensors | |||
There was a problem hiding this comment.
why is this corresponding signature not updated? some compatibility issue?
There was a problem hiding this comment.
Thanks, we just made the fix.
crtrentz
force-pushed
the
typehinting-bools
branch
from
8aa3330 to
015040e
Compare
Co-authored-by: Benjamin Gorman <[email protected]>
hjmjohnson
force-pushed
the
typehinting-bools
branch
from
015040e to
09a7703
Compare
Nic-Ma
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Benjamin Gorman [email protected]
Description
Remove (bool) from docstrings and add corresponding type hints. (part of #476)
Status
Ready
Types of changes