476 Reconfigure mypy and pytype #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
force-pushed
the
reconfigure-checks
branch
3 times, most recently
from
2ddb9f1 to
4cec2dd
Compare
ghost
changed the title
ghost
force-pushed
the
reconfigure-checks
branch
3 times, most recently
from
06294a6 to
8ae42ec
Compare
|
@hjmjohnson Updated and checks pass |
hjmjohnson
approved these changes
Aug 3, 2020
| @@ -183,7 +183,7 @@ def _get_up_layer( | |||
|
|
|||
| return conv | |||
|
|
|||
| def forward(self, x: torch.Tensor): | |||
| def forward(self, x: torch.Tensor) -> torch.Tensor: | |||
- Enable as many checks as possible - Allow redefinition for mypy to match pytype - Allow redefinition for pythonic code
|
@benjamin-gorman This needs updating again based on recent merges. |
added 3 commits
August 4, 2020 11:06
- Update type: ignore to specify error - Update type hints to specify contents - Add type hints to parameters - Add type hints to returns - Remove unnecessary type hints - Remove incorrect type hints - Rename internal variables (redefinition) - Resolve errors as a result of the above
- Stick with no redefinition for stricter, explicit typing
ghost
force-pushed
the
reconfigure-checks
branch
from
52a6981 to
974f14e
Compare
wyli
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iteration of #476
Description
Reconfigure mypy and pytype
Resolve errors, Add and Update type hints
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage.