Skip to content

Add targets for macOS, tvOS, watchOS #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2017
Merged

Add targets for macOS, tvOS, watchOS #16

merged 4 commits into from
Mar 30, 2017

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Mar 24, 2017

This PR adds framework targets, unit test bundle targets, and schemes for macOS, tvOS, and watchOS. Carthage uses these targets to install this library into macOS, tvOS, and watchOS application targets. CocoaPods support for these platforms was added in #13.

This PR also removes “.swift” from the bundle identifier and renames the umbrella header to use camel case, per convention.

Fixes #5. Depends on #14.

/cc @frederoni @freenerd

@1ec5 1ec5 self-assigned this Mar 24, 2017
@1ec5 1ec5 requested a review from bsudekum March 24, 2017 21:22
@1ec5 1ec5 mentioned this pull request Mar 24, 2017
@1ec5 1ec5 force-pushed the 1ec5-platforms-5 branch 2 times, most recently from 7195abe to 262d54a Compare March 29, 2017 19:07
@1ec5 1ec5 force-pushed the 1ec5-platforms-5 branch from 262d54a to 8c5085e Compare March 30, 2017 18:28
@1ec5
Copy link
Member Author

1ec5 commented Mar 30, 2017

By the way, the build failures are because .travis.yml won’t exist until #17 lands, but Travis (unlike Bitrise) insists that the file has to exist on every branch simultaneously. Only a temporary inconvenience.

@1ec5 1ec5 merged commit 14e772d into master Mar 30, 2017
@1ec5 1ec5 deleted the 1ec5-platforms-5 branch March 30, 2017 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants