Skip to content

Remove left/right from exit announcement. #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

willwhite
Copy link
Contributor

Hi @freenerd. This PR does what you wanted in #116 (comment).

@willwhite willwhite mentioned this pull request Jul 7, 2017
Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we reinstate left/right more selectively once we support country-specific guidance (Project-OSRM/osrm-backend#2772)? I think the danger of omitting “on the left” (or “on the right” in left-handed countries) outweighs the verbosity of “on the right” (“on the left” in left-handed countries) in the normal case.

My suggestion in #116 (review) was merely to be consistent between the exit and exit_destination cases.

@willwhite
Copy link
Contributor Author

I think the danger of omitting “on the left” (or “on the right” in left-handed countries) outweighs the verbosity of “on the right” (“on the left” in left-handed countries) in the normal case.

I was leaning in this direction when I first wrote the PR but after seeing it live the verbosity is pretty offensive. The plan would be to get this straitened out once we know which countries drive on which side.

@bsudekum
Copy link

bsudekum commented Jul 7, 2017

Yeah, I'm in favor of keeping left/right in favor of verbosity. This information is important when the exit ramp is actually on the left, since this does actually happen.

@willwhite
Copy link
Contributor Author

Closing in favor of #125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants