Preserve bit locations through pickle #13980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when we were pickling a DAGCircuit the bit locations fields were forgotten about. So when we loaded a DAGCircuit from a pickle the bit locations were empty. This would cause any call to find_bit() to raise an error because there was no entry for any of the bits in the dag. This commit fixes this by reconstructing the bit locations on __setstate__ by iterating over the dag's qubits and clbits. Fixes Qiskit#13976
mtreinish
added
the
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
mtreinish
added
the
stable backport potential
Pull Request Test Coverage Report for Build 13821976559Details
💛 - Coveralls |
1 task
kevinhartman
previously approved these changes
Mar 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ElePT
approved these changes
Mar 13, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
* Preserve bit locations through pickle Previously when we were pickling a DAGCircuit the bit locations fields were forgotten about. So when we loaded a DAGCircuit from a pickle the bit locations were empty. This would cause any call to find_bit() to raise an error because there was no entry for any of the bits in the dag. This commit fixes this by reconstructing the bit locations on __setstate__ by iterating over the dag's qubits and clbits. Fixes #13976 * Fix clippy * Update docstrings * Fix name change after rebase (cherry picked from commit 9dcc668)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
* Preserve bit locations through pickle (#13980) * Preserve bit locations through pickle Previously when we were pickling a DAGCircuit the bit locations fields were forgotten about. So when we loaded a DAGCircuit from a pickle the bit locations were empty. This would cause any call to find_bit() to raise an error because there was no entry for any of the bits in the dag. This commit fixes this by reconstructing the bit locations on __setstate__ by iterating over the dag's qubits and clbits. Fixes #13976 * Fix clippy * Update docstrings * Fix name change after rebase (cherry picked from commit 9dcc668) * Fix method name for stable/2.0 vs main --------- Co-authored-by: Matthew Treinish <[email protected]>
raynelfss
pushed a commit
to raynelfss/qiskit
that referenced
this pull request
Mar 20, 2025
* Preserve bit locations through pickle Previously when we were pickling a DAGCircuit the bit locations fields were forgotten about. So when we loaded a DAGCircuit from a pickle the bit locations were empty. This would cause any call to find_bit() to raise an error because there was no entry for any of the bits in the dag. This commit fixes this by reconstructing the bit locations on __setstate__ by iterating over the dag's qubits and clbits. Fixes Qiskit#13976 * Fix clippy * Update docstrings * Fix name change after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously when we were pickling a DAGCircuit the bit locations fields were forgotten about. So when we loaded a DAGCircuit from a pickle the bit locations were empty. This would cause any call to find_bit() to raise an error because there was no entry for any of the bits in the dag. This commit fixes this by reconstructing the bit locations on setstate by iterating over the dag's qubits and clbits.
Details and comments
Fixes #13976