-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix deepcopy/pickle of DAGCircuit
variable IO nodes (backport #14041)
#14044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Fix var DAGOutNode bug in DAGCircuit::pack_into. We were accidentally using NodeType::VarIn when extracting DAGOutNode. * Add release note since this is pre 2.0.0. (cherry picked from commit ddd0401) # Conflicts: # crates/circuit/src/dag_circuit.rs
Cherry-pick of ddd0401 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13924716828Details
💛 - Coveralls |
Summary
Fixes a typo we've had for a while in
DAGCircuit::pack_into
that would causeVar
output nodes to become input nodes duringdeepcopy
or pickling.Details and comments
The
DAGCircuit::pack_into
method is only called with IO nodes from withinDAGCircuit::__setstate__
, so this bug would only trigger for deep-copied or un-pickled DAGs with variables.This is an automatic backport of pull request #14041 done by Mergify.