[WIP] Add ruff configuration to pyproject.toml

pyproject.toml

@@ -21,3 +21,26 @@ before-test = "pip install --only-binary=numpy,scipy numpy scipy"
 [tool.cibuildwheel.linux]
 before-all = "yum install -y wget && {package}/tools/install_rust.sh"
 environment = 'PATH="$PATH:$HOME/.cargo/bin" CARGO_NET_GIT_FETCH_WITH_CLI="true"'
+
+
+[tool.ruff]
+line-length=105
+
+[tool.ruff.per-file-ignores]
+"__init__.py" = ["F401", "E402"] # imported but unused, Module level import not at top of file
+"qiskit/circuit/library/__init__.py" = ["F403"] # import * used
+"qiskit/extensions/__init__.py" = ["F403"]
+"qiskit/providers/fake_provider/__init__.py" = ["F403"]
+"qiskit/visualization/pulse/__init__.py" = ["F403"]
+"qiskit/opflow/operator_globals.py" = ["E741"] # Ambiguous variable name `I`
+"qiskit/quantum_info/operators/random.py" = ["F401"] # Should be fixed.
+"qiskit/quantum_info/random.py" = ["F401"] # Should be fixed.
+"qiskit/synthesis/discrete_basis/solovay_kitaev.py" = ["F821"] # Undefined name
+"qiskit/test/decorators.py" = ["F401"] # `qiskit.providers.aer` imported but unused
+"qiskit/tools/visualization.py"  = ["F403"]
+"qiskit/transpiler/passes/calibration/builders.py" = ["F401"]
+"qiskit/transpiler/passes/optimization/hoare_opt.py" = ["F401"]
+"qiskit/transpiler/passes/scheduling/calibration_creators.py" = ["F401"]
+"qiskit/transpiler/passes/scheduling/rzx_templates.py" = ["F401"]
+
+

qiskit/algorithms/amplitude_estimators/ae_utils.py

@@ -39,20 +39,20 @@ def bisect_max(f, a, b, steps=50, minwidth=1e-12, retval=False):
     m = (a + b) / 2
     fm = 0
     while it < steps and b - a > minwidth:
-        l, r = (a + m) / 2, (m + b) / 2
-        fl, fm, fr = f(l), f(m), f(r)
+        left, r = (a + m) / 2, (m + b) / 2
+        fl, fm, fr = f(left), f(m), f(r)
 
         # fl is the maximum
         if fl > fm and fl > fr:
             b = m
-            m = l
+            m = left
         # fr is the maximum
         elif fr > fm and fr > fl:
             a = m
             m = r
         # fm is the maximum
         else:
-            a = l
+            a = left
             b = r
 
         it += 1

qiskit/algorithms/gradients/spsa_sampler_gradient.py

@@ -127,7 +127,7 @@ def _run(
             gradient = []
             indices = [circuits[i].parameters.data.index(p) for p in metadata[i]["parameters"]]
             for j in range(circuits[i].num_parameters):
-                if not j in indices:
+                if j not in indices:
                     continue
                 # the gradient for jth parameter is the average of the gradients of the jth parameter
                 # for each batch.

qiskit/algorithms/optimizers/gsls.py

@@ -115,7 +115,7 @@ def minimize(
             var_lb = np.array([-np.inf] * x0.size)
             var_ub = np.array([np.inf] * x0.size)
         else:
-            var_lb = np.array([l for (l, _) in bounds])
+            var_lb = np.array([lower for (lower, _) in bounds])
             var_ub = np.array([u for (_, u) in bounds])
 
         x, fun, nfev, njev = self.ls_optimize(x0.size, fun, x0, var_lb, var_ub)

qiskit/algorithms/optimizers/nlopts/nloptimizer.py

@@ -97,8 +97,8 @@ def minimize(
             bounds = [(None, None)] * x0.size
 
         threshold = 3 * np.pi
-        low = [(l if l is not None else -threshold) for (l, u) in bounds]
-        high = [(u if u is not None else threshold) for (l, u) in bounds]
+        low = [(lower if lower is not None else -threshold) for (lower, u) in bounds]
+        high = [(u if u is not None else threshold) for (lower, u) in bounds]
 
         name = self._optimizer_names[self.get_nlopt_optimizer()]
         opt = nlopt.opt(name, len(low))

qiskit/algorithms/optimizers/p_bfgs.py

@@ -128,8 +128,8 @@ def minimize(
         threshold = 2 * np.pi
         if bounds is None:
             bounds = [(-threshold, threshold)] * x0.size
-        low = [(l if l is not None else -threshold) for (l, u) in bounds]
-        high = [(u if u is not None else threshold) for (l, u) in bounds]
+        low = [(lower if lower is not None else -threshold) for (lower, u) in bounds]
+        high = [(u if u is not None else threshold) for (lower, u) in bounds]
 
         def optimize_runner(_queue, _i_pt):  # Multi-process sampling
             _sol, _opt, _nfev = self._optimize(fun, _i_pt, jac, bounds)

qiskit/algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py

@@ -84,7 +84,7 @@ def lse_solver(self) -> Callable[[np.ndarray, np.ndarray], np.ndarray]:
     def lse_solver(self, lse_solver: Callable[[np.ndarray, np.ndarray], np.ndarray] | None) -> None:
         """Sets an LSE solver. Uses a ``np.linalg.lstsq`` callable if ``None`` provided."""
         if lse_solver is None:
-            lse_solver = lambda a, b: np.linalg.lstsq(a, b, rcond=1e-2)[0]
+            def lse_solver(a, b): return np.linalg.lstsq(a, b, rcond=1e-2)[0]
 
         self._lse_solver = lse_solver
 

qiskit/providers/fake_provider/fake_provider.py

@@ -19,7 +19,102 @@
 from qiskit.providers.provider import ProviderV1
 from qiskit.providers.exceptions import QiskitBackendNotFoundError
 
-from .backends import *
+from .backends import (
+            FakeAlmaden,
+            FakeArmonk,
+            FakeAthens,
+            FakeBelem,
+            FakeBoeblingen,
+            FakeBogota,
+            FakeBrooklyn,
+            FakeBurlington,
+            FakeCairo,
+            FakeCambridge,
+            FakeCambridgeAlternativeBasis,
+            FakeCasablanca,
+            FakeEssex,
+            FakeGuadalupe,
+            FakeHanoi,
+            FakeJakarta,
+            FakeJohannesburg,
+            FakeKolkata,
+            FakeLagos,
+            FakeLima,
+            FakeLondon,
+            FakeManila,
+            FakeManhattan,
+            FakeMelbourne,
+            FakeMontreal,
+            FakeMumbai,
+            FakeNairobi,
+            FakeOurense,
+            FakeParis,
+            FakePoughkeepsie,
+            FakeQuito,
+            FakeRochester,
+            FakeRome,
+            FakeRueschlikon,
+            FakeSantiago,
+            FakeSingapore,
+            FakeSydney,
+            FakeTenerife,
+            FakeTokyo,
+            FakeToronto,
+            FakeValencia,
+            FakeVigo,
+            FakeWashington,
+            FakeYorktown,
+    )
+
+from .backends import (
+            FakeAlmadenV2,
+            FakeArmonkV2,
+            FakeAthensV2,
+            FakeAuckland,
+            FakeBelemV2,
+            FakeBoeblingenV2,
+            FakeBogotaV2,
+            FakeBrooklynV2,
+            FakeBurlingtonV2,
+            FakeCairoV2,
+            FakeCambridgeV2,
+            FakeCasablancaV2,
+            FakeEssexV2,
+            FakeGeneva,
+            FakeGuadalupeV2,
+            FakeHanoiV2,
+            FakeJakartaV2,
+            FakeJohannesburgV2,
+            FakeKolkataV2,
+            FakeLagosV2,
+            FakeLimaV2,
+            FakeLondonV2,
+            FakeManhattanV2,
+            FakeManilaV2,
+            FakeMelbourneV2,
+            FakeMontrealV2,
+            FakeMumbaiV2,
+            FakeNairobiV2,
+            FakeOslo,
+            FakeOurenseV2,
+            FakeParisV2,
+            FakePerth,
+            FakePrague,
+            FakePoughkeepsieV2,
+            FakeQuitoV2,
+            FakeRochesterV2,
+            FakeRomeV2,
+            FakeSantiagoV2,
+            FakeSherbrooke,
+            FakeSingaporeV2,
+            FakeSydneyV2,
+            FakeTorontoV2,
+            FakeValenciaV2,
+            FakeVigoV2,
+            FakeWashingtonV2,
+            FakeYorktownV2,
+)
+
 from .fake_qasm_simulator import FakeQasmSimulator
 from .fake_openpulse_2q import FakeOpenPulse2Q
 from .fake_openpulse_3q import FakeOpenPulse3Q

qiskit/quantum_info/synthesis/xx_decompose/paths.py

@@ -100,7 +100,7 @@ def decomposition_hop(target_coordinate, strengths):
         specialized_polytope = PolytopeData(
             convex_subpolytopes=[
                 ConvexPolytopeData(
-                    inequalities=[[v, h, l] for ((h, l), v) in coefficient_dict.items()]
+                    inequalities=[[v, h, ineq2] for ((h, ineq2), v) in coefficient_dict.items()]
                 )
             ]
         )

qiskit/result/mitigation/utils.py

@@ -115,8 +115,8 @@ def marganalize_counts(
 ) -> np.ndarray:
     """Marginalization of the Counts. Verify that number of clbits equals to the number of qubits."""
     if clbits is not None:
-        qubits_len = len(qubits) if not qubits is None else 0
-        clbits_len = len(clbits) if not clbits is None else 0
+        qubits_len = len(qubits) if qubits is not None else 0
+        clbits_len = len(clbits) if clbits is not None else 0
         if clbits_len not in (0, qubits_len):
             raise QiskitError(
                 "Num qubits ({}) does not match number of clbits ({}).".format(

qiskit/synthesis/clifford/clifford_decompose_layers.py

@@ -387,5 +387,5 @@ def _check_gates(qc, allowed_gates):
     allowed_gates - list of strings
     """
     for inst, _, _ in qc.data:
-        if not inst.name in allowed_gates:
+        if inst.name not in allowed_gates:
             raise QiskitError("The gate name is not in the allowed_gates list.")

qiskit/transpiler/passes/synthesis/unitary_synthesis.py

@@ -153,7 +153,7 @@ def _error(circuit, target=None, qubits=None):
             for key in keys:
                 target_op = target.operation_from_name(key)
                 # pylint: disable=unidiomatic-typecheck
-                if type(target_op) == type(inst.operation) and (
+                if type(target_op) == type(inst.operation) and ( # noqa: E721 Do not compare types
                     target_op.is_parameterized()
                     or all(
                         isclose(float(p1), float(p2))

qiskit/transpiler/synthesis/graysynth.py

@@ -21,7 +21,7 @@
 
 # Redirect getattrs to modules new location
 # TODO: Deprecate in 0.24.0 and remove in 0.26.0
-from qiskit.synthesis.linear.graysynth import *
+from qiskit.synthesis.linear.graysynth import * # noqa: F403
 
 
 def cnot_synth(state, section_size=2):
@@ -51,4 +51,4 @@ def cnot_synth(state, section_size=2):
            Quantum Information & Computation 8.3 (2008): 282-294.
            `arXiv:quant-ph/0302002 [quant-ph] <https://arxiv.org/abs/quant-ph/0302002>`_
     """
-    return synth_cnot_count_full_pmh(state, section_size=section_size)
+    return synth_cnot_count_full_pmh(state, section_size=section_size) # noqa: F405

qiskit/transpiler/target.py

@@ -39,7 +39,8 @@
 
 # import QubitProperties here to provide convenience alias for building a
 # full target
-from qiskit.providers.backend import QubitProperties  # pylint: disable=unused-import
+# pylint: disable=unused-import
+from qiskit.providers.backend import QubitProperties # noqa: F401
 from qiskit.providers.models.backendproperties import BackendProperties
 
 logger = logging.getLogger(__name__)

qiskit/utils/backend_utils.py

@@ -53,8 +53,8 @@ def has_ibmq():
     """Check if IBMQ is installed"""
     if not _PROVIDER_CHECK.checked_ibmq:
         try:
-            from qiskit.providers.ibmq import IBMQFactory
-            from qiskit.providers.ibmq.accountprovider import AccountProvider
+            from qiskit.providers.ibmq import IBMQFactory # noqa: F401
+            from qiskit.providers.ibmq.accountprovider import AccountProvider # noqa: F401
 
             _PROVIDER_CHECK.has_ibmq = True
         except Exception as ex:  # pylint: disable=broad-except
@@ -70,7 +70,7 @@ def has_aer():
     """check if Aer is installed"""
     if not _PROVIDER_CHECK.checked_aer:
         try:
-            from qiskit.providers.aer import AerProvider
+            from qiskit.providers.aer import AerProvider # noqa: F401
 
             _PROVIDER_CHECK.has_aer = True
         except Exception as ex:  # pylint: disable=broad-except

qiskit/utils/mitigation/circuits.py

@@ -37,10 +37,10 @@ def count_keys(num_qubits: int) -> List[str]:
 
 def complete_meas_cal(
     qubit_list: List[int] = None,
-    qr: Union[int, List["QuantumRegister"]] = None,
-    cr: Union[int, List["ClassicalRegister"]] = None,
+    qr: Union[int, List["QuantumRegister"]] = None, # noqa: F821
+    cr: Union[int, List["ClassicalRegister"]] = None, # noqa: F821
     circlabel: str = "",
-) -> Tuple[List["QuantumCircuit"], List[str]]:
+) -> Tuple[List["QuantumCircuit"], List[str]]: # noqa: F821
     """
     Return a list of measurement calibration circuits for the full
     Hilbert space.
@@ -114,10 +114,10 @@ def complete_meas_cal(
 
 def tensored_meas_cal(
     mit_pattern: List[List[int]] = None,
-    qr: Union[int, List["QuantumRegister"]] = None,
-    cr: Union[int, List["ClassicalRegister"]] = None,
+    qr: Union[int, List["QuantumRegister"]] = None, # noqa: F821
+    cr: Union[int, List["ClassicalRegister"]] = None, # noqa: F821
     circlabel: str = "",
-) -> Tuple[List["QuantumCircuit"], List[List[int]]]:
+) -> Tuple[List["QuantumCircuit"], List[List[int]]]: # noqa: F821
     """
     Return a list of calibration circuits
 

qiskit/visualization/circuit_visualization.py

@@ -16,4 +16,4 @@
 
 # Temporary import from 0.22.0 to be deprecated in future
 # pylint: disable=unused-import
-from .circuit.circuit_visualization import circuit_drawer
+from .circuit.circuit_visualization import circuit_drawer # noqa: F401

qiskit/visualization/gate_map.py

@@ -910,7 +910,7 @@ def plot_error_map(backend, figsize=(12, 9), show_title=True, qubit_coordinates=
             directed = False
             if num_qubits < 20:
                 for edge in cmap:
-                    if not [edge[1], edge[0]] in cmap:
+                    if [edge[1], edge[0]] not in cmap:
                         directed = True
                         break
 
@@ -956,7 +956,7 @@ def plot_error_map(backend, figsize=(12, 9), show_title=True, qubit_coordinates=
             directed = False
             if num_qubits < 20:
                 for edge in cmap:
-                    if not [edge[1], edge[0]] in cmap:
+                    if [edge[1], edge[0]] not in cmap:
                         directed = True
                         break
             for line in cmap.get_edges():

qiskit/visualization/qcstyle.py

@@ -14,4 +14,4 @@
 
 # Temporary import from 0.22.0 to be deprecated in future
 # pylint: disable=unused-wildcard-import,wildcard-import
-from .circuit.qcstyle import *
+from .circuit.qcstyle import * # noqa: F403