Develop branch for release after ROCm 7.0 #1022
Open
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daineAMD
requested review from
amcamd,
TorreZuk,
mahmoodw,
bragadeesh,
NaveenElumalaiAMD and
rkamd
as code owners
TorreZuk
approved these changes
May 21, 2025
| rocm_package_add_dependencies(SHARED_DEPENDS "rocblas >= ${rocblas_minimum}" "rocsolver >= ${rocsolver_minimum}") | ||
| rocm_package_add_rpm_dependencies(STATIC_DEPENDS "rocblas-static-devel >= ${rocblas_minimum}" "rocsolver-static-devel >= ${rocsolver_minimum}") | ||
| rocm_package_add_deb_dependencies(STATIC_DEPENDS "rocblas-static-dev >= ${rocblas_minimum}" "rocsolver-static-dev >= ${rocsolver_minimum}") | ||
| endif( ) | ||
|
|
||
| set(hipblas_common_minimum 1.1.0) |
There was a problem hiding this comment.
Well for dependencies not sure if we have a tight or loose policy for minimum version. Think solver must be loose as they always talk about using older rocblas too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hipblas-common dep. for release-staging/rocm-rel-7.0 branch is v 1.1 but should probably be changed to 1.2 to be consistent. I'll make a change to that branch unless anyone thinks otherwise.
Pending rocsolver version and hipblas-common merge.