cellSaveData improvements #5792

knight4u32 · 2019-04-05T09:22:49Z

Write vblank semaphore.
Remove reader lock on current texture invalidation task check for every instruction RSX FIFO, replace it with optimistic check instead (optimistic that it won't lock).
Fix a few verification failures with sys_lwcond/mutex HLE while closing the emulator. (regarding mutex state)
Fix race on ::emu_requested flip flag when native ui is activated, fixes Cars: Race-O-Rama - Cannot load game saves #5458.
Reschedule in cellMsgDialogOpen2.
Fix sys_spu group id base and step.

SaveData fixes:

Add error checking for intial arguments for savedata_op(), most of them were REd directly.
Add short sleep periods in places were the firmware executes cellSysutilPacketRead and releasing the thread, fixes [Bounty: $5]Family Guy: Back To The Multiverse [BLES01625] does not run #5711.
Return error code when statSet>setParam is NULL and dir doesnt exist. fixes Fritz Chess [BLES00559] issue #5744 , fixes savedata: cellSaveDataUserAutoLoad called with a directory that doesn't exist (Regression) #4124.
Return error code when statSet->setParam is NULL and the reCreateMode is specified to delete save folder contents. testcase for both of the above.
Fix sizeKb when save folder only contains PARAM.SFO (not included in the file list).

rpcs3/Emu/RSX/GL/GLGSRender.cpp

kd-11 · 2019-04-05T12:07:27Z

rpcs3/Emu/Cell/lv2/sys_rsx.cpp

@@ -459,6 +459,7 @@ error_code sys_rsx_context_attribute(s32 context_id, u32 package_id, u64 a3, u64

 	case 0xFED: // hack: vblank command
 		// todo: this is wrong and should be 'second' vblank handler and freq, but since currently everything is reported as being 59.94, this should be fine
+		vm::_ref<u32>(render->ctxt_addr + 0x30) = 1;


Thanks, meant to implement this at some point before vsh stuff was merged.

AniLeo · 2019-04-05T16:46:19Z

Fixes LOTR: Conquest savedata regression, and it no longer complains about current savedata being corrupted when loading it.

uaqlover · 2019-04-09T13:59:17Z

@elad335 with your pr i test it Cars: Race-O-Rama #5458 still Cannot load game saves

here the video

https://drive.google.com/file/d/1htp_JVeL0F3Mimn19DEkzFKpBqkqfU4y/view?usp=sharing

and log file

RPCS3 cars.log.gz

knight4u32 · 2019-04-09T14:22:12Z

ah I see, atleast you can start a new save now.

rpcs3/Emu/RSX/rsx_methods.cpp

rpcs3/Emu/RSX/RSXThread.cpp

kd-11 · 2019-04-09T17:44:12Z

rpcs3/Emu/RSX/RSXThread.cpp

-			reader_lock lock(m_mtx_task);
-
-			if (m_invalidated_memory_range.valid())
+			if (atomic_storage<u32>::load(m_invalidated_memory_range.end) != 0)


Thanks! Missed this one.

CesarAxe · 2019-04-09T22:13:09Z

This PR fix the problem when loading the saved data in SAW 2 when native ui option is enabled.

ghost · 2019-04-16T21:00:13Z

STOP 1 has nothing to do with STOP 0 hack. It's an instruction for disgaea patches.

In general, I'm against merging last 2 commits (regarding sys_spu_thread_group_terminate and STOP hack removal). There is an order in doing things like hack removal and I don't see an explicit problem with them being as is.

AniLeo · 2019-04-16T21:05:42Z

Is everything else ok? I suggest moving the other two commits to a newer PR then for further discussion and merging the rest as is, the savedata fixes are well needed

Use optimistic double check instead, use one load instruction for the check to be atomic + Read emu status once every FIFO iteration

Fixes a few verification failures while closing the emulator with HLE liblv2

TODO: There are probably more spots where we should yield. A little more at the start because PacketRead is called twice. Dont use sys_timer_usleep because it will just call this_thread::yield() repeatedly.

* Check directory existence if setParam is NULL (dont create directory) * Fix mask for reCreateMode * Check a few setParam fields including reserved buffers. * Fix sizeKb when the dir is empty except from PARAM.SFO * Fix error checking when CELL_SAVEDATA_RECREATE_YES is specified but setParam is NULL (Doesnt do anything, simply errors)

ghost · 2019-04-19T22:08:10Z

rpcs3/Emu/RSX/rsx_methods.cpp

 		{
 			rsx->sync_point_request = true;
 			const u32 addr = get_address(method_registers.semaphore_offset_406e(), method_registers.semaphore_context_dma_406e());
-			if (vm::read32(addr) == arg) return;
+
+#ifdef IS_LE_MACHINE


Forgot to complain... That's not a sort of loop to benefit from removing one 1-cycle byteswap op, especially with so much code madness.

knight4u32 force-pushed the hle_fixes branch from 393bc9a to 02a4fec Compare April 5, 2019 12:02

kd-11 reviewed Apr 5, 2019

View reviewed changes

rpcs3/Emu/RSX/GL/GLGSRender.cpp Outdated Show resolved Hide resolved

kd-11 reviewed Apr 5, 2019

View reviewed changes

knight4u32 force-pushed the hle_fixes branch 3 times, most recently from 52f5363 to ba34955 Compare April 5, 2019 15:50

AniLeo added Bugfix Enhancement Firmware: HLE Savedata Anything that involves cellSaveData labels Apr 5, 2019

uaqlover mentioned this pull request Apr 6, 2019

[NPUB30811] Ferrari Racing Legends is loading infinitely #5796

Closed

knight4u32 force-pushed the hle_fixes branch from e7713b8 to db8de22 Compare April 7, 2019 12:48

uaqlover mentioned this pull request Apr 8, 2019

issue with NASCAR '14 and 15 #5803

Closed

knight4u32 force-pushed the hle_fixes branch 4 times, most recently from 3669ebc to 6856371 Compare April 9, 2019 11:08

kd-11 reviewed Apr 9, 2019

View reviewed changes

rpcs3/Emu/RSX/rsx_methods.cpp Outdated Show resolved Hide resolved

kd-11 reviewed Apr 9, 2019

View reviewed changes

rpcs3/Emu/RSX/RSXThread.cpp Outdated Show resolved Hide resolved

kd-11 reviewed Apr 9, 2019

View reviewed changes

knight4u32 force-pushed the hle_fixes branch 2 times, most recently from 71d166d to 2d17801 Compare April 9, 2019 20:35

knight4u32 force-pushed the hle_fixes branch from 2d17801 to 7b204f6 Compare April 10, 2019 03:48

knight4u32 mentioned this pull request Apr 10, 2019

New UI: freeze while saving. #4146

Closed

AniLeo requested a review from kd-11 April 10, 2019 14:39

knight4u32 force-pushed the hle_fixes branch from 7b204f6 to 6ea18b6 Compare April 10, 2019 15:28

kd-11 approved these changes Apr 11, 2019

View reviewed changes

knight4u32 force-pushed the hle_fixes branch 2 times, most recently from 70ba944 to 935fcfc Compare April 12, 2019 09:49

Luffykun007 approved these changes Apr 12, 2019

View reviewed changes

uaqlover mentioned this pull request Apr 13, 2019

PPU: Games that still don't work with LLVM recompiler #5831

Open

46 tasks

knight4u32 force-pushed the hle_fixes branch from 935fcfc to 51b3a2b Compare April 16, 2019 06:06

knight4u32 force-pushed the hle_fixes branch from 51b3a2b to 347a8b6 Compare April 17, 2019 00:06

knight4u32 added 3 commits April 17, 2019 03:07

rsx: Write vblank semahpre, minor semaphore acquire optimization

f0824d6

Remove reader_lock executed in every instruction by RSX

5111c96

Use optimistic double check instead, use one load instruction for the check to be atomic + Read emu status once every FIFO iteration

Put missing check_state() in some places

9de2e08

Fixes a few verification failures while closing the emulator with HLE liblv2

knight4u32 force-pushed the hle_fixes branch from 347a8b6 to ed4cfea Compare April 17, 2019 00:08

knight4u32 added 7 commits April 17, 2019 03:10

Implement initial arguments error checking for cellSaveData

1cac995

Improve scheduler control for cellSaveData

5e95d64

TODO: There are probably more spots where we should yield. A little more at the start because PacketRead is called twice. Dont use sys_timer_usleep because it will just call this_thread::yield() repeatedly.

Fix sys_spu group ID

f62b195

rsx: Fix race on clearing native_ui vs emu_requested flag

d5e44b7

Reschedule in cellMsgDialogOpen2

3b6236d

Fix cellSaveDataListAutoSave/Load unk flags

930c238

knight4u32 force-pushed the hle_fixes branch from ed4cfea to 930c238 Compare April 17, 2019 00:12

AniLeo requested a review from a user April 17, 2019 00:28

Merge branch 'master' into hle_fixes

9a19e2a

ghost merged commit ae5a4b6 into RPCS3:master Apr 19, 2019

ghost reviewed Apr 19, 2019

View reviewed changes

ghost mentioned this pull request Apr 20, 2019

Regression : GRAN TURISMO HD Concept [NPEA90002] save doesn't work #5868

Closed

k10kan mentioned this pull request Apr 20, 2019

[Regression Tracker] PR #5785 (rsx: Texture cache fixes) #5869

Closed

5 tasks

AniLeo added the RSX label Apr 20, 2019

CesarAxe mentioned this pull request Apr 21, 2019

SAW II [BLES01050] input issue with regular Qt dialogs #5746

Closed

knight4u32 deleted the hle_fixes branch April 26, 2019 04:01

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

cellSaveData improvements #5792

cellSaveData improvements #5792

Uh oh!

knight4u32 commented Apr 5, 2019 •

edited

Loading

Uh oh!

Uh oh!

kd-11 Apr 5, 2019

Uh oh!

AniLeo commented Apr 5, 2019

Uh oh!

uaqlover commented Apr 9, 2019

Uh oh!

knight4u32 commented Apr 9, 2019

Uh oh!

Uh oh!

Uh oh!

kd-11 Apr 9, 2019

Uh oh!

CesarAxe commented Apr 9, 2019 •

edited

Loading

Uh oh!

ghost commented Apr 16, 2019

Uh oh!

AniLeo commented Apr 16, 2019

Uh oh!

ghost Apr 19, 2019

Uh oh!

Uh oh!

Uh oh!

cellSaveData improvements #5792

cellSaveData improvements #5792

Uh oh!

Conversation

knight4u32 commented Apr 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kd-11 Apr 5, 2019

Choose a reason for hiding this comment

Uh oh!

AniLeo commented Apr 5, 2019

Uh oh!

uaqlover commented Apr 9, 2019

Uh oh!

knight4u32 commented Apr 9, 2019

Uh oh!

Uh oh!

Uh oh!

kd-11 Apr 9, 2019

Choose a reason for hiding this comment

Uh oh!

CesarAxe commented Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Apr 16, 2019

Uh oh!

AniLeo commented Apr 16, 2019

Uh oh!

ghost Apr 19, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

knight4u32 commented Apr 5, 2019 •

edited

Loading

CesarAxe commented Apr 9, 2019 •

edited

Loading