Skip to content

Defining jquery-ui as dependency instead of jquery.ui #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

stollr
Copy link

@stollr stollr commented Jul 25, 2022

In the AMD definition the 'jquery.ui' dependency seem to be invalid. Building a project with webpack results in this error:

ERROR Failed to compile with 1 errors

This dependency was not found:

  • jquery.ui in ./node_modules/@rwap/jquery-ui-touch-punch/jquery.ui.touch-punch.js

Using 'jquery-ui' instead of 'jquery.ui' fixes that.

In the AMD definition the 'jquery.ui' dependency is invalid. Building a project with webpack results in this error:

> ERROR  Failed to compile with 1 errors
>
> This dependency was not found:
>
> * jquery.ui in ./node_modules/@rwap/jquery-ui-touch-punch/jquery.ui.touch-punch.js

Using 'jquery-ui' fixes that.
@RWAP RWAP merged commit bb49a73 into RWAP:master Jul 25, 2022
@melloware
Copy link

Nice additions @Naitsirch

@stollr
Copy link
Author

stollr commented Jul 27, 2022

You're welcome @melloware :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants