Skip to content

Replace deprecated $.fn.bind/unbind #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

smartexcan
Copy link

Related:
f847786
#27

When the deprecated $.proxy was replaced, the deprecated $.fn.bind and $.fn.unbind were used instead of changing only the use of proxy to the native function bind method.

This PR corrects this and adds the intended changes.

@RWAP RWAP merged commit ed60e6d into RWAP:master Mar 8, 2024
@melloware
Copy link

We should bump the comments in the file to 1.1.2

@RWAP
Copy link
Owner

RWAP commented Mar 8, 2024

Done

@melloware
Copy link

@smartexcan is this working for you? with this change all my integration tests seem to be failing with a Javscript error

Javascript errors were detected in the browser console.

[[2024-03-08T16:17:50.388Z] [SEVERE] http://localhost:8247/jakarta.faces.resource/jquery/jquery-plugins.js.xhtml?ln=primefaces&v=14.0.0-SNAPSHOT&v=14.0.0-SNAPSHOT 11340:49 
Uncaught TypeError: Cannot read properties of undefined (reading 'bind')

@RWAP
Copy link
Owner

RWAP commented Mar 8, 2024

There is indeed a slight error in line 199 - correcting now

@melloware
Copy link

Thanks Integration tests passing again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants