Allow ARC to use mockter as a TS guess adapter #784
+58
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -238,7 +238,21 @@ | |||
| Set the input_file_memory attribute. | |||
| """ | |||
| self.input_file_memory = self.job_memory_gb | |||
|
|
|||
|
|
|||
| def get_mock_xyz(self): | |||
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, we need to add an explicit return statement at the end of the get_mock_xyz function to handle cases where none of the conditions are met. This will ensure that the function always returns a value explicitly, making the code easier to read and understand.
- Add an explicit return statement at the end of the
get_mock_xyzfunction. - The return value should be
Noneto maintain the existing functionality.
Suggested changeset
1
arc/job/adapters/mockter.py
| @@ -254,3 +254,3 @@ | ||
| return str_to_xyz(ts_xyz_str) | ||
|
|
||
| return None | ||
| def execute_incore(self): |
Copilot is powered by AI and may make mistakes. Always verify output.
alongd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will be used for functional tests of ARC and T3
Tests added