Skip to content

Mark model fields for translation #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bmihelac opened this issue Aug 1, 2024 · 4 comments
Closed

Mark model fields for translation #94

bmihelac opened this issue Aug 1, 2024 · 4 comments
Labels
database-backend Issues relating to the database backend good first issue Good for newcomers

Comments

@bmihelac
Copy link
Contributor

bmihelac commented Aug 1, 2024

It would be nice to mark DBTaskResult model fields and status labels for translation so they can be translated if needed.

Please close this issue if it is too early for translations.
@RealOrangeOne
Copy link
Owner

What do you imagine would be translated?

@RealOrangeOne RealOrangeOne added more-info-needed Further information is requested database-backend Issues relating to the database backend labels Aug 1, 2024
@bmihelac
Copy link
Contributor Author

bmihelac commented Aug 1, 2024

I guess everything that is visible in admin, that is:

  • DBTaskResult model verbose_name, verbose_name_plural
  • all DBTaskResult fields verbose name
  • ResultStatus labels

@RealOrangeOne
Copy link
Owner

Good point - I'd definitely welcome a PR to improve this!

@RealOrangeOne RealOrangeOne added good first issue Good for newcomers and removed more-info-needed Further information is requested labels Aug 2, 2024
@bmihelac
Copy link
Contributor Author

bmihelac commented Aug 2, 2024

Great - I'll prepare PR.

bmihelac added a commit to bmihelac/django-tasks that referenced this issue Aug 2, 2024
@bmihelac
Mark ResultStatus labels and DBTaskResult fields for translation (Rea…
8493970 
…lOrangeOne#94)
bmihelac added a commit to bmihelac/django-tasks that referenced this issue Aug 2, 2024
@bmihelac
Mark ResultStatus labels and DBTaskResult fields for translation (Rea…
59308a6 
…lOrangeOne#94)
bmihelac added a commit to bmihelac/django-tasks that referenced this issue Aug 2, 2024
@bmihelac
Mark ResultStatus labels and DBTaskResult fields for translation (Rea…
d11984b 
…lOrangeOne#94)
bmihelac added a commit to bmihelac/django-tasks that referenced this issue Aug 2, 2024
@bmihelac
Mark ResultStatus labels and DBTaskResult fields for translation (Rea…
1718a58 
…lOrangeOne#94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database-backend Issues relating to the database backend good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmihelac @RealOrangeOne