Improve concurrency coverage #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local mypy was a little out of date
This ensures the same task can't be claimed by multiple workers. This does impact throughput on SQLite, but retries should help with this.
RealOrangeOne
force-pushed
the
test-concurrency
branch
from
a14ec71 to
986de9f
Compare
Seeing another decorator may imply there's a reason for it. As this code doesn't use SQLite, we can use the existing method.
This will only have an effect on Django 5.1+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
This PR uses
EXCLUSIVEtransactions on SQLite, which a task can only be claimed once, at the cost of throughput.I've also improved the coverage for
get_locked, ensuring it actually locks rows as it's expected to.