-
Notifications
You must be signed in to change notification settings - Fork 38
[Virt] Removes EFI boot for cloning tests on s390x #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: s390x
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
for more information, see https://pre-commit.ci
The base branch was changed.
Co-authored-by: Ohad Revah <[email protected]>
* feat: refactor image architectures * fix versions and refactor functio location * get os from py_config only if exists * add missing file * fix tox and use global_config_x86.py * add todo on cirros s390x class * catch AttributeError it not set * catch AttributeError it not set * catch AttributeError it not set * update get_test_images_arch_class to upper * address comments and refactor archs * Move base images to data classes * add markers to pytest.ini * address comments * address review comments * add to tox * fix tox * update markers description * address comments * fix dataclasses * add OS_VERSION_STR to all * add docstrings * fix pre-commit * fix missing matrix flows * update gcp ini file * fix windows dir * fix dir assignment * update readme * re-add removed test
Short description:
Adds support of test on s390x by changing to bios boots for vm cloning tests
More details:
What this PR does / why we need it:
Allows
tests/virt/cluster/vm_cloning/test_vm_cloning.py
to be run on s390x archWhich issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket: