adjust dv size to fit GCP minimumSupportedPvcSize #1246

Ahmad-Hafe · 2025-06-19T15:22:24Z

Short description:

this PR is following the new cloud providors storage class, gcp, aro, arm etcc... that is supporting minimumSupportedPvcSize > 4Gi
there are few tests that are failing because they use dv's that are smaller than minimumSupportedPvcSize, 1Gi etc ...

More details:

there are many test that are failing due to small dv size, need to adjust these test accordingly to minimumSupportedPvcSize, size changed dynamiclly + added a function that fetch the minimumSupportedPvcSize from the storage profile

https://docs.google.com/presentation/d/1wDDKB0ZGbRpObNP9hqSu2Rm8OdccRTQ1St-eNEQaFYM/edit?slide=id.g317d1609066_0_17#slide=id.g317d1609066_0_17

https://drive.google.com/file/d/1MT99MArNHn4e85APbvrawDZydQzHxslk/view

What this PR does / why we need it:

there are many test that are failing due to small dv size, need to adjust these test accordingly to minimumSupportedPvcSiz from storgae profile

Which issue(s) this PR fixes:

T2 failuers
https://jenkins-csb-cnvqe-main.dno.corp.redhat.com/job/test-pytest-cnv-4.19-storage-gcp/5/testReport/

Special notes for reviewer:

jira-ticket:

https://issues.redhat.com/browse/CNV-63567

coderabbitai · 2025-06-19T15:22:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

openshift-virtualization-qe-bot

D/S test tox -e verify-bugs-are-open failed: cnv-tests-tox-executor/13262

Ahmad-Hafe · 2025-07-01T07:38:27Z

/wip cancel

jpeimer · 2025-07-01T08:03:36Z

tests/storage/cdi_upload/test_upload_virtctl.py

@@ -237,7 +239,7 @@ def test_virtctl_image_upload_pvc(download_image, namespace, storage_class_name_
        namespace=namespace.name,
        pvc=True,
        name=pvc_name,
-        size="1Gi",
+        size=storage_profile_minimum_supported_pvc_size,


So if we do this now, and the next provisioner will have a 2Gi minimum size limitation - how will we catch it?

jpeimer · 2025-07-01T08:05:30Z

tests/storage/utils.py

        storage_class=storage_class,
        access_modes=access_modes,
        volume_mode=volume_mode,
        client=client,
+        size=get_default_storage_profile_minimum_supported_pvc_size(),
    ) as dv:


This function gets a storage_class, will get_default_storage_profile_minimum_supported_pvc_size return the value for the same storage_class?

jpeimer · 2025-07-01T08:07:41Z

tests/storage/conftest.py

+@pytest.fixture(scope="session")
+def xfail_test_if_gcp_sc(cluster_storage_classes):
+    existing_gcp_sc = [sc.name for sc in cluster_storage_classes if sc.name in StorageClassNames.GCP]
+    if existing_gcp_sc:
+        pytest.xfail(
+            reason=f"This test is X failed due to non supporting GCP storage class dv less than 4Gi'{existing_gcp_sc}'"
+        )


If my cluster has GCP and OCS, and I'm running the test on OCS, this would xfail anyway?

jpeimer · 2025-07-01T08:10:20Z

tests/storage/cdi_import/test_import_http.py

@@ -542,6 +542,7 @@ def test_blank_disk_import_validate_status(data_volume_multi_storage_scope_funct
    ],
 )
 def test_vmi_image_size(
+    xfail_test_if_gcp_sc,


For the 13Gi param - this test can still run
What should happen if we requested 64M, but got 4Gi PVC? Should VMI see the 4Gi?

jpeimer · 2025-07-01T08:13:57Z

tests/utils.py

@@ -585,7 +587,7 @@ def create_cirros_vm(
        source="http",
        url=get_http_image_url(image_directory=Images.Cirros.DIR, image_name=Images.Cirros.QCOW2_IMG),
        storage_class=storage_class,
-        size=Images.Cirros.DEFAULT_DV_SIZE,
+        size=get_default_storage_profile_minimum_supported_pvc_size(),


For http import, storage profile annotation should handle this, no?

stesrn · 2025-07-02T12:32:34Z

tests/utils.py

+
+def get_default_storage_profile_minimum_supported_pvc_size() -> str:
+    return StorageProfile(
+        name=next(iter(py_config["system_storage_class_matrix"][0]))


Instead of deducing the storage profile name using 'next(item(py_config["system_storage_class_matrix"][0]))' , is that good to pass the storage class name directly to this function and make use of it here ? (i.e) get_default_storage_profile_minimum_supported_pvc_size(storage_class=storage_class)

openshift-virtualization-qe-bot previously approved these changes Jun 19, 2025

View reviewed changes

Ahmad-Hafe dismissed openshift-virtualization-qe-bot’s stale review via 2fe5613 June 19, 2025 16:31

Ahmad-Hafe force-pushed the adjust_dv_size_for_gcp branch from 14bc1f5 to 2fe5613 Compare June 19, 2025 16:31

openshift-virtualization-qe-bot previously approved these changes Jun 19, 2025

View reviewed changes

Ahmad-Hafe dismissed openshift-virtualization-qe-bot’s stale review via 1a3af9f June 19, 2025 16:52

Ahmad-Hafe force-pushed the adjust_dv_size_for_gcp branch from 2fe5613 to 1a3af9f Compare June 19, 2025 16:52

openshift-virtualization-qe-bot previously approved these changes Jun 19, 2025

View reviewed changes

openshift-virtualization-qe-bot requested changes Jun 30, 2025

View reviewed changes

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing labels Jun 30, 2025

openshift-virtualization-qe-bot removed the wip label Jul 1, 2025

openshift-virtualization-qe-bot changed the title ~~WIP: adjust dv size to fit GCP minimumSupportedPvcSize~~ adjust dv size to fit GCP minimumSupportedPvcSize Jul 1, 2025

adjust dv size to fit GCP minimumSupportedPvcSize

dc2e27a

Ahmad-Hafe force-pushed the adjust_dv_size_for_gcp branch from dc8c8ea to dc2e27a Compare July 1, 2025 07:38

openshift-virtualization-qe-bot-3 removed the changes-requested-openshift-virtualization-qe-bot label Jul 1, 2025

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing and removed tox:verify-tc-requirement-polarion:passed D/S Testing labels Jul 1, 2025

Ahmad-Hafe requested a review from openshift-virtualization-qe-bot July 1, 2025 07:41

openshift-virtualization-qe-bot approved these changes Jul 1, 2025

View reviewed changes

openshift-virtualization-qe-bot added the lgtm-openshift-virtualization-qe-bot label Jul 1, 2025

jpeimer requested changes Jul 1, 2025

View reviewed changes

openshift-virtualization-qe-bot-3 added the changes-requested-jpeimer label Jul 1, 2025

stesrn reviewed Jul 2, 2025

View reviewed changes

openshift-virtualization-qe-bot added the commented-stesrn label Jul 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adjust dv size to fit GCP minimumSupportedPvcSize #1246

adjust dv size to fit GCP minimumSupportedPvcSize #1246

Uh oh!

Ahmad-Hafe commented Jun 19, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 19, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

openshift-virtualization-qe-bot left a comment

Uh oh!

Ahmad-Hafe commented Jul 1, 2025

Uh oh!

jpeimer Jul 1, 2025

Uh oh!

jpeimer Jul 1, 2025

Uh oh!

jpeimer Jul 1, 2025

Uh oh!

jpeimer Jul 1, 2025

Uh oh!

jpeimer Jul 1, 2025

Uh oh!

stesrn Jul 2, 2025

Uh oh!

Uh oh!

adjust dv size to fit GCP minimumSupportedPvcSize #1246

Are you sure you want to change the base?

adjust dv size to fit GCP minimumSupportedPvcSize #1246

Uh oh!

Conversation

Ahmad-Hafe commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Uh oh!

coderabbitai bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

openshift-virtualization-qe-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Ahmad-Hafe commented Jul 1, 2025

Uh oh!

jpeimer Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

jpeimer Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

jpeimer Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

jpeimer Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

jpeimer Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

stesrn Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Ahmad-Hafe commented Jun 19, 2025 •

edited

Loading

coderabbitai bot commented Jun 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)