Update model label in kubevirt_vm/i_vnic_info metrics #1322

OhadRevah · 2025-06-29T13:56:05Z

Short description:

A new label added to the metrics
kubevirt_vm_vnic_info
kubevirt_vmi_vnic_info
Added check to validate this label in the test.

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

https://issues.redhat.com/browse/CNV-64484

Summary by CodeRabbit

Tests
- Enhanced test fixtures to include network interface model information.
- Updated test setup to explicitly set the network model to VIRTIO for virtual machine instances.

A new label added to the metrics kubevirt_vm_vnic_info kubevirt_vmi_vnic_info Added check to validate this label in the test.

openshift-virtualization-qe-bot-2 · 2025-06-29T13:56:17Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Pre-commit Checks: pre-commit runs automatically if .pre-commit-config.yaml exists
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No WIP, hold, or conflict labels
Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

dshchedr
myakove
rnetser
vsibirsk

Reviewers:

OhadRevah
RoniKishner
dshchedr
hmeir
rnetser
vsibirsk

Available Labels

hold
verified
wip
lgtm
approve
automerge

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is automatically removed on each new commit
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

coderabbitai · 2025-06-29T13:56:24Z

Walkthrough

The changes update test fixtures to explicitly set the network model to VIRTIO when creating test virtual machines and to extract and return the network interface model in the VNIC information fixture. This involves modifying fixture logic and import statements in test configuration files.

Changes

Files/Paths	Change Summary
tests/observability/metrics/conftest.py	Updated the `vnic_info_from_vm_or_vmi` fixture to extract the VM interface to a variable and return its `model` attribute in the result dictionary.
tests/conftest.py	Added `VIRTIO` to imports and modified the `running_metric_vm` fixture to set `network_model=VIRTIO` in the VM creation.

Suggested labels

verified, size/XS, can-be-merged, lgtm-rnetser, approved-rnetser

Suggested reviewers

hmeir
rnetser
RoniKishner
vsibirsk
dshchedr

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dda9e2 and fb64b29.

📒 Files selected for processing (2)

tests/conftest.py (2 hunks)
tests/observability/metrics/conftest.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/observability/metrics/conftest.py

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: akri3i
PR: RedHatQE/openshift-virtualization-tests#1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

Learnt from: akri3i
PR: RedHatQE/openshift-virtualization-tests#1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:142-149
Timestamp: 2025-06-23T19:18:12.275Z
Learning: In OpenShift Virtualization machine type transition tests, the kubevirt_api_lifecycle_automation_job updates VM machine types to the latest version based on a MACHINE_TYPE_GLOB pattern, and subsequent fixtures may intentionally revert the machine type to test bidirectional transition behavior.

Learnt from: akri3i
PR: RedHatQE/openshift-virtualization-tests#1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/conftest.py:1065-1077
Timestamp: 2025-06-18T09:21:34.315Z
Learning: In tests/observability/metrics/conftest.py, when creating fixtures that modify shared Windows VM state (like changing nodeSelector), prefer using function scope rather than class scope to ensure ResourceEditor context managers properly restore the VM state after each test, maintaining test isolation while still reusing expensive Windows VM fixtures.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/test_vms_metrics.py:129-137
Timestamp: 2025-06-18T09:19:05.769Z
Learning: For Windows VM testing in tests/observability/metrics/test_vms_metrics.py, it's acceptable to have more fixture parameters than typical pylint recommendations when reusing expensive Windows VM fixtures for performance. Windows VMs take a long time to deploy, so reusing fixtures like windows_vm_for_test and adding labels via windows_vm_with_low_bandwidth_migration_policy is preferred over creating separate fixtures that would require additional VM deployments.

Learnt from: jpeimer
PR: RedHatQE/openshift-virtualization-tests#1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

Learnt from: jpeimer
PR: RedHatQE/openshift-virtualization-tests#954
File: tests/storage/storage_migration/conftest.py:264-269
Timestamp: 2025-05-28T10:50:56.122Z
Learning: In the openshift-virtualization-tests codebase, cleanup pytest fixtures like `deleted_old_dvs_of_stopped_vms`, `deleted_completed_virt_launcher_source_pod`, and `deleted_old_dvs_of_online_vms` do not require yield statements. These fixtures perform cleanup operations and work correctly without yielding values.

Learnt from: dshchedr
PR: RedHatQE/openshift-virtualization-tests#890
File: tests/virt/node/descheduler/conftest.py:146-148
Timestamp: 2025-06-13T01:08:18.579Z
Learning: The fixture `vms_orig_nodes_before_node_drain` in tests/virt/node/descheduler/conftest.py is intentionally kept with the “node_drain” suffix because it represents the state directly before a node drain step; future refactor suggestions should preserve this name unless requirements change.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/conftest.py:1065-1077
Timestamp: 2025-06-18T09:31:06.311Z
Learning: In tests/observability/metrics/conftest.py, ResourceEditor context managers automatically restore VM configuration when the context exits, including nodeSelector patches. The fixture pattern with `with ResourceEditor(patches={vm: {...}})` followed by `yield` properly restores the VM to its original state without requiring manual teardown logic.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/conftest.py:1183-1186
Timestamp: 2025-06-22T13:47:35.014Z
Learning: In tests/observability/metrics/conftest.py, the `stopped_windows_vm` fixture is designed to temporarily stop the Windows VM for a test, then restart it during teardown (after yield) because the Windows VM is module-scoped and needs to be available for other tests that depend on it being in a running state.

Learnt from: akri3i
PR: RedHatQE/openshift-virtualization-tests#1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/test_mass_machine_type_transition.py:97-104
Timestamp: 2025-06-23T19:24:28.327Z
Learning: In OpenShift Virtualization machine type transition tests, the test_machine_type_transition_without_restart method with restart_required=false parameter validates that VM machine types do NOT change when the lifecycle job runs with restart disabled, so the assertion should check against the original machine type rather than the target machine type.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/conftest.py:1178-1180
Timestamp: 2025-06-18T09:15:25.436Z
Learning: In tests/observability/metrics/conftest.py, the `stopped_vm_metric_1` fixture is intentionally designed to stop the VM and leave it in that state - it does not need to restart the VM afterward as this is the desired behavior for the tests that use it.

tests/conftest.py (12)

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/conftest.py:1065-1077
Timestamp: 2025-06-18T09:21:34.315Z
Learning: In tests/observability/metrics/conftest.py, when creating fixtures that modify shared Windows VM state (like changing nodeSelector), prefer using function scope rather than class scope to ensure ResourceEditor context managers properly restore the VM state after each test, maintaining test isolation while still reusing expensive Windows VM fixtures.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/test_vms_metrics.py:129-137
Timestamp: 2025-06-18T09:19:05.769Z
Learning: For Windows VM testing in tests/observability/metrics/test_vms_metrics.py, it's acceptable to have more fixture parameters than typical pylint recommendations when reusing expensive Windows VM fixtures for performance. Windows VMs take a long time to deploy, so reusing fixtures like windows_vm_for_test and adding labels via windows_vm_with_low_bandwidth_migration_policy is preferred over creating separate fixtures that would require additional VM deployments.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/conftest.py:1178-1180
Timestamp: 2025-06-18T09:15:25.436Z
Learning: In tests/observability/metrics/conftest.py, the `stopped_vm_metric_1` fixture is intentionally designed to stop the VM and leave it in that state - it does not need to restart the VM afterward as this is the desired behavior for the tests that use it.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/conftest.py:1183-1186
Timestamp: 2025-06-22T13:47:35.014Z
Learning: In tests/observability/metrics/conftest.py, the `stopped_windows_vm` fixture is designed to temporarily stop the Windows VM for a test, then restart it during teardown (after yield) because the Windows VM is module-scoped and needs to be available for other tests that depend on it being in a running state.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#584
File: tests/observability/metrics/test_network_metrics.py:62-76
Timestamp: 2025-05-27T11:44:14.859Z
Learning: The windows_vm_for_test fixture in tests/observability/metrics/conftest.py does not have a request argument, so it cannot be parametrized using @pytest.mark.parametrize with indirect=True. This is different from vm_for_test fixture which accepts parameters through parametrization.

Learnt from: dshchedr
PR: RedHatQE/openshift-virtualization-tests#890
File: tests/virt/node/descheduler/conftest.py:146-148
Timestamp: 2025-06-13T01:08:18.579Z
Learning: The fixture `vms_orig_nodes_before_node_drain` in tests/virt/node/descheduler/conftest.py is intentionally kept with the “node_drain” suffix because it represents the state directly before a node drain step; future refactor suggestions should preserve this name unless requirements change.

Learnt from: akri3i
PR: RedHatQE/openshift-virtualization-tests#1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:142-149
Timestamp: 2025-06-23T19:18:12.275Z
Learning: In OpenShift Virtualization machine type transition tests, the kubevirt_api_lifecycle_automation_job updates VM machine types to the latest version based on a MACHINE_TYPE_GLOB pattern, and subsequent fixtures may intentionally revert the machine type to test bidirectional transition behavior.

Learnt from: OhadRevah
PR: RedHatQE/openshift-virtualization-tests#1166
File: tests/observability/metrics/conftest.py:1065-1077
Timestamp: 2025-06-18T09:31:06.311Z
Learning: In tests/observability/metrics/conftest.py, ResourceEditor context managers automatically restore VM configuration when the context exits, including nodeSelector patches. The fixture pattern with `with ResourceEditor(patches={vm: {...}})` followed by `yield` properly restores the VM to its original state without requiring manual teardown logic.

Learnt from: jpeimer
PR: RedHatQE/openshift-virtualization-tests#954
File: tests/storage/storage_migration/conftest.py:264-269
Timestamp: 2025-05-28T10:50:56.122Z
Learning: In the openshift-virtualization-tests codebase, cleanup pytest fixtures like `deleted_old_dvs_of_stopped_vms`, `deleted_completed_virt_launcher_source_pod`, and `deleted_old_dvs_of_online_vms` do not require yield statements. These fixtures perform cleanup operations and work correctly without yielding values.

Learnt from: jpeimer
PR: RedHatQE/openshift-virtualization-tests#1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

Learnt from: rnetser
PR: RedHatQE/openshift-virtualization-tests#983
File: tests/virt/node/high_performance_vm/test_high_performance_templates.py:144-144
Timestamp: 2025-05-28T09:59:39.558Z
Learning: In the OpenShift Virtualization tests, f-string image path construction with potential None values is acceptable during test collection because tests are filtered during execution based on architecture and pyconfig settings. Tests that would have None values for architecture-specific images won't actually execute.

Learnt from: rnetser
PR: RedHatQE/openshift-virtualization-tests#983
File: utilities/constants.py:163-168
Timestamp: 2025-05-18T07:36:10.674Z
Learning: In the OpenShift Virtualization tests, architecture constants like X86_64, AMD_64, ARM_64, and S390X need to be included in the get_test_images_arch_class() validation check to be fully supported.

🔇 Additional comments (2)

tests/conftest.py (2)

120-120: LGTM! Import addition supports the fixture enhancement.

The addition of VIRTIO to the constants import is necessary to support the explicit network model configuration in the running_metric_vm fixture below.

2296-2296: LGTM! Explicit network model ensures consistent metrics testing.

Setting network_model=VIRTIO explicitly in the running_metric_vm fixture ensures that VMs used for metrics testing have a consistent network interface model. This aligns perfectly with the PR objectives to update VM/VNIC info metrics with model labels and enables reliable validation of the new label.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

OhadRevah · 2025-06-29T14:01:13Z

/build-and-push-container

openshift-virtualization-qe-bot · 2025-06-29T14:02:25Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-1322 published

OhadRevah · 2025-06-29T14:05:41Z

/retest build-container

OhadRevah · 2025-06-30T08:03:39Z

/verified

rnetser · 2025-06-30T17:23:14Z

tests/observability/metrics/conftest.py

+@pytest.fixture(scope="class")
+def vm_for_test_with_network_model(namespace, unprivileged_client):
+    vm_name = "vm-with-network-model"
+    with VirtualMachineForTests(


@vsibirsk @dshchedr any reason to continue using VirtualMachineForTests and not move to BaseVirtualMachine?

tests/observability/metrics/conftest.py

OhadRevah · 2025-07-01T17:33:10Z

/build-and-push-container

openshift-virtualization-qe-bot · 2025-07-01T17:34:07Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-1322 published

rnetser · 2025-07-02T09:39:10Z

/approve
/lgtm

OhadRevah · 2025-07-02T14:02:00Z

/verified

Update model label in kubevirt_vm/i_vnic_info metrics

4dda9e2

A new label added to the metrics kubevirt_vm_vnic_info kubevirt_vmi_vnic_info Added check to validate this label in the test.

openshift-virtualization-qe-bot-2 requested a review from hmeir June 29, 2025 13:56

openshift-virtualization-qe-bot-2 assigned OhadRevah Jun 29, 2025

openshift-virtualization-qe-bot-2 mentioned this pull request Jun 29, 2025

Update model label in kubevirt_vm/i_vnic_info metrics - 1322 #1323

Open

openshift-virtualization-qe-bot-2 requested review from vsibirsk and RoniKishner June 29, 2025 13:56

openshift-virtualization-qe-bot-2 added size/S branch-main labels Jun 29, 2025

openshift-virtualization-qe-bot-2 requested review from dshchedr and rnetser June 29, 2025 13:56

openshift-virtualization-qe-bot approved these changes Jun 29, 2025

View reviewed changes

openshift-virtualization-qe-bot added the lgtm-openshift-virtualization-qe-bot label Jun 29, 2025

vsibirsk previously approved these changes Jun 30, 2025

View reviewed changes

openshift-virtualization-qe-bot added the lgtm-vsibirsk label Jun 30, 2025

openshift-virtualization-qe-bot-3 added the verified label Jun 30, 2025

rnetser requested changes Jun 30, 2025

View reviewed changes

openshift-virtualization-qe-bot-3 added the changes-requested-rnetser label Jun 30, 2025

openshift-virtualization-qe-bot-3 requested a review from rnetser July 1, 2025 06:59

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:passed D/S Testing tox:verify-bugs-are-open:running D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-bugs-are-open:passed D/S Testing labels Jul 1, 2025

openshift-virtualization-qe-bot added tox:verify-bugs-are-open:passed D/S Testing and removed tox:verify-bugs-are-open:running D/S Testing labels Jul 1, 2025

openshift-virtualization-qe-bot approved these changes Jul 1, 2025

View reviewed changes

openshift-virtualization-qe-bot-3 added the lgtm-openshift-virtualization-qe-bot label Jul 1, 2025

openshift-virtualization-qe-bot added approved-rnetser lgtm-rnetser labels Jul 2, 2025

Merge branch 'main' into addLabelModel

ca64285

openshift-virtualization-qe-bot-2 removed lgtm-rnetser approved-rnetser lgtm-openshift-virtualization-qe-bot labels Jul 2, 2025

openshift-virtualization-qe-bot-2 requested a review from rlobillo July 2, 2025 14:00

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing and removed tox:verify-tc-requirement-polarion:passed D/S Testing labels Jul 2, 2025

openshift-virtualization-qe-bot-3 added the verified label Jul 2, 2025

openshift-virtualization-qe-bot approved these changes Jul 2, 2025

View reviewed changes

openshift-virtualization-qe-bot-2 added the lgtm-openshift-virtualization-qe-bot label Jul 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update model label in kubevirt_vm/i_vnic_info metrics #1322

Update model label in kubevirt_vm/i_vnic_info metrics #1322

OhadRevah commented Jun 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 29, 2025

Uh oh!

coderabbitai bot commented Jun 29, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

OhadRevah commented Jun 29, 2025

Uh oh!

openshift-virtualization-qe-bot commented Jun 29, 2025

Uh oh!

OhadRevah commented Jun 29, 2025

Uh oh!

OhadRevah commented Jun 30, 2025

Uh oh!

rnetser Jun 30, 2025

Uh oh!

Uh oh!

OhadRevah commented Jul 1, 2025

Uh oh!

openshift-virtualization-qe-bot commented Jul 1, 2025

Uh oh!

rnetser commented Jul 2, 2025

Uh oh!

OhadRevah commented Jul 2, 2025

Uh oh!

Uh oh!

Update model label in kubevirt_vm/i_vnic_info metrics #1322

Are you sure you want to change the base?

Update model label in kubevirt_vm/i_vnic_info metrics #1322

Conversation

OhadRevah commented Jun 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

Uh oh!

openshift-virtualization-qe-bot-2 commented Jun 29, 2025

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

coderabbitai bot commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

OhadRevah commented Jun 29, 2025

Uh oh!

openshift-virtualization-qe-bot commented Jun 29, 2025

Uh oh!

OhadRevah commented Jun 29, 2025

Uh oh!

OhadRevah commented Jun 30, 2025

Uh oh!

rnetser Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OhadRevah commented Jul 1, 2025

Uh oh!

openshift-virtualization-qe-bot commented Jul 1, 2025

Uh oh!

rnetser commented Jul 2, 2025

Uh oh!

OhadRevah commented Jul 2, 2025

Uh oh!

Uh oh!

OhadRevah commented Jun 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)