Skip to content

MOD-9917 MOD-9918 initial rust result processor bindings and infrastructure #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 11, 2025

Conversation

JonasKruckenberg
Copy link
Collaborator

Describe the changes in the pull request

This PR defines the ResultProcessor trait and implements basic infrastructure required for writing result processors in Rust. To make reviewing easier, this PR does not include any result processor implementations and does not impact the redisearch binary at all.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@github-actions github-actions bot added the size:M label Jun 3, 2025
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 90.74074% with 25 lines in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (5cdd236) to head (ee8b843).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/redisearch_rs/result_processor/src/lib.rs 90.74% 24 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6250    +/-   ##
========================================
  Coverage   88.85%   88.86%            
========================================
  Files         240      241     +1     
  Lines       40524    40794   +270     
  Branches     3165     3435   +270     
========================================
+ Hits        36008    36251   +243     
- Misses       4481     4507    +26     
- Partials       35       36     +1     
Flag Coverage Δ
flow 82.21% <ø> (-0.12%) ⬇️
unit 46.33% <90.74%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

DarthB
DarthB previously requested changes Jun 4, 2025
Copy link
Collaborator

@DarthB DarthB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-add the RPCounter Rust implementation as an example.

@JonasKruckenberg JonasKruckenberg force-pushed the push-rxqmlwqtlwnw branch 2 times, most recently from 0ae84d2 to b30d6dc Compare June 4, 2025 12:09
@JonasKruckenberg JonasKruckenberg changed the title [MOD-9917] initial rust result processor bindings and infrastructure MOD-9917 initial rust result processor bindings and infrastructure Jun 4, 2025
@JonasKruckenberg JonasKruckenberg force-pushed the push-rxqmlwqtlwnw branch 2 times, most recently from ad62cd2 to 03ba543 Compare June 5, 2025 08:53
@github-actions github-actions bot added the size:L label Jun 5, 2025
@JonasKruckenberg JonasKruckenberg requested a review from kei-nan June 11, 2025 08:36
@JonasKruckenberg JonasKruckenberg changed the title MOD-9917 initial rust result processor bindings and infrastructure MOD-9917 MOD-9884 initial rust result processor bindings and infrastructure Jun 11, 2025
@JonasKruckenberg JonasKruckenberg changed the title MOD-9917 MOD-9884 initial rust result processor bindings and infrastructure MOD-9917 MOD-9918 initial rust result processor bindings and infrastructure Jun 11, 2025
Copy link
Collaborator

@DarthB DarthB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.

@DarthB DarthB dismissed their stale review June 11, 2025 15:21

outdated

Copy link
Collaborator

@DarthB DarthB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonasKruckenberg JonasKruckenberg added this pull request to the merge queue Jun 11, 2025
Merged via the queue into master with commit ffa4012 Jun 11, 2025
14 checks passed
@JonasKruckenberg JonasKruckenberg deleted the push-rxqmlwqtlwnw branch June 11, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants