-
Notifications
You must be signed in to change notification settings - Fork 552
MOD-9917 MOD-9918 initial rust result processor bindings and infrastructure #6250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6250 +/- ##
========================================
Coverage 88.85% 88.86%
========================================
Files 240 241 +1
Lines 40524 40794 +270
Branches 3165 3435 +270
========================================
+ Hits 36008 36251 +243
- Misses 4481 4507 +26
- Partials 35 36 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-add the RPCounter
Rust implementation as an example.
0ae84d2
to
b30d6dc
Compare
ad62cd2
to
03ba543
Compare
f545e60
to
0864a69
Compare
ab7b344
to
cb7b36a
Compare
cb7b36a
to
c9df352
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe the changes in the pull request
This PR defines the
ResultProcessor
trait and implements basic infrastructure required for writing result processors in Rust. To make reviewing easier, this PR does not include any result processor implementations and does not impact the redisearch binary at all.Mark if applicable