Skip to content

Remove punycode polyfill #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tre2man opened this issue Apr 21, 2024 · 2 comments
Closed

Remove punycode polyfill #52

tre2man opened this issue Apr 21, 2024 · 2 comments

Comments

@tre2man
Copy link

tre2man commented Apr 21, 2024

The funycode seems to be deprecated.

(node:43949) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
@Richienb
Copy link
Owner

This is a problem with your code: your code is importing the punycode module, which is deprecated.

Instead, install the similarly named punycode userland module from npm and import it like require('punycode/'), noting the forward slash (/).

@Richienb Richienb closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
@Richienb Richienb changed the title The funycode seems to be deprecated. punycode seems to be deprecated. May 24, 2024
@Richienb Richienb changed the title punycode seems to be deprecated. punycode is deprecated May 24, 2024
@Richienb Richienb changed the title punycode is deprecated Remove punycode polyfill May 24, 2024
@Richienb Richienb reopened this May 24, 2024
@Richienb
Copy link
Owner

Richienb commented May 24, 2024 •
edited
Loading

I think it is worth stopping polyfilling punycode since there is no longer any practical use now. (maybe time to separate out into compat- and recommended- configs)?

Richienb added a commit that referenced this issue May 24, 2024
@Richienb
Stop polyfilling console, 'domain', process, and internal `stream…
abbc328 
…` modules by default; rename `includeAliases` to `additionalAliases`, and allow ignoring the defaults with `onlyAliases`

Fixes #40, #52, #18, #44

Signed-off-by: Richie Bendall <[email protected]>
Richienb added a commit that referenced this issue May 24, 2024
@Richienb
Stop polyfilling console, 'domain', process, and internal `stream…
542075d 
…` modules by default; rename `includeAliases` to `additionalAliases`, and allow ignoring the defaults with `onlyAliases`

Fixes #40, fixes #52, fixes #18, fixes #44

Signed-off-by: Richie Bendall <[email protected]>
Richienb added a commit that referenced this issue May 24, 2024
@Richienb
Stop polyfilling console, 'domain', process, and internal `stream…
08f793b 
…` modules by default; rename `includeAliases` to `additionalAliases`, and allow ignoring the defaults with `onlyAliases`

Fixes #40, fixes #52, fixes #18, fixes #44, fixes #20

Signed-off-by: Richie Bendall <[email protected]>
Richienb added a commit that referenced this issue May 24, 2024
@afonsojramos @Richienb
Add fs null fallback (#45)
010fc94 
* feat: add `fs` fallback

* Update readme.md

* Stop polyfilling `console`, 'domain', `process`, and internal `stream` modules by default; rename `includeAliases` to `additionalAliases`, and allow ignoring the defaults with `onlyAliases`

Fixes #40, fixes #52, fixes #18, fixes #44

Signed-off-by: Richie Bendall <[email protected]>

* Add as default

Signed-off-by: Richie Bendall <[email protected]>

* Update readme.md

---------

Signed-off-by: Richie Bendall <[email protected]>
Co-authored-by: Richie Bendall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Richienb @tre2man