ENH: Liquid Motors #233
Merged
ENH: Liquid Motors #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovaniceotto
added
Enhancement
8 tasks
21 tasks
…rtia ENH: liquid motors tank inertia
ENH: Liquid Motors Updates
|
Some simulations were not adjusted yet, and therefore they can't be ran without errors, currently. These simulations are:
However, they can easily be modified in future PRs. |
Co-authored-by: Guilherme <[email protected]>
'RocketPy-Team/beta/v1.0.0' into enh/liquid-motors
- update SolidMotor definition - wrong assert in in test_rail_length - tanks have no gasInertiaTensor attribute
- improve underfilled/overfilled errors - set discrete when extremely necessary
- SEBLM: changing the railLength to Flight class - Tank class usage: fix TODOs
Gui-FernandesBR
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Absolutely amazing work here!
To all the 8 collaborators, I should give you congratulations for conducting such development along the past months.
This is by far the biggest change we have introduced into RocketPy since it was created, and it would not be possible without the Berkeley team!
- All conversations resolved
- Notebooks with examples are running properly
- We are ready to merge it
Update rocketpy/Function.py Co-authored-by: MateusStano <[email protected]>
Update rocketpy/Function.py Co-authored-by: phmbressan <[email protected]>
enh/move-liquid-plots-and-prints
- Sort imports - avoid printing blank lines - more prints and plots for tank geometry
…thods ENH: Resetable Funcified Methods
…prints ENH: Move Motor Plots and Prints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @phmbressan
Co-authored-by: @MrGribel
Co-authored-by: @MateusStano
Co-authored-by: @ompro07
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
RocketPy does not support Rockets powered by Liquid Rocket Engines.
What is the new behavior?
A
LiquidMotorclass is created based on theMotorabstract class. It makes use of other new classes:Tank,UllageBasedTank,MassBasedTank,MassFlowRateBasedTankandFluid.Does this introduce a breaking change?
from rocketpy.Motor import SolidMotordoes not work anymore. Instead, one will need to usefrom rocketpy import SolidMotororfrom rocketpy.motors import SolidMotor.Other information
Other Pull Requests will be created to complement this one before this can be approved and merged.
TODO List