-
-
Notifications
You must be signed in to change notification settings - Fork 194
ENH: Refactoring Flight Plots #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Gui-FernandesBR
wants to merge
19
commits into
enh/complex_simulations
from
enh/complex_simulations_refactor_plots
Closed
ENH: Refactoring Flight Plots #252
Gui-FernandesBR
wants to merge
19
commits into
enh/complex_simulations
from
enh/complex_simulations_refactor_plots
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are working offline but not on github, I have no clue of what is going on |
8 tasks
REL: Automate Release to PyPI with GitHub Actions
Hotfix for issues 251 and 261
3 tasks
This PR will be desconsidered. @MateusStano is about to create another PR based on The branch will be preserved so we can use the code in the future if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
New feature or request, including adjustments in current codes
Outputs
Dedicated to visualizations enhancements like prints and plots
Refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyCode base additions (for bug fixes / features):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyWhat is the current behavior?
It's quite hard to compare different aspects of a flight when you have more than 1 stage rocket.
Also, a lot of code lines at Flight.py are dedicated exclusively
What is the new behavior?
Does this introduce a breaking change?
Other information
Quite large pull request... But I swear, once you get the idea of one plot, you'll definetely understand the other. The trick part is only about how to initialize the flight_plots class, I confess that I'm not so pround of the difficult to initialize the class, but it's working properly anyway.
Many thanks to github copilot, this little guys has worked like hell past couple days.