Skip to content

ENH: Liquid Motors Mass Flow Based Tank #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 9, 2022
Merged

ENH: Liquid Motors Mass Flow Based Tank #254

merged 21 commits into from
Oct 9, 2022

Conversation

giovaniceotto
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the new behavior?

Add an implementation of a Mass Flow Rate Based Tank to support Liquid Motors

Does this introduce a breaking change?

  • Yes
  • No

MrGribel and others added 14 commits October 6, 2022 11:51
@MrGribel
ENH: add mass flow rate based tank and inertia tensor method
689eee2
@MrGribel
MAINT: changed way mass integration interval is defined
224dc64
@MrGribel
MAINT: change mass flow rate methods into cached properties
7b0080d
@MrGribel
ENH: changes to init files to import Tank classes
b6cf06f
@MrGribel
ENH: multiple small changes in LiquidMotor class to get it to work
8dade91
@MrGribel
ENH: test data and notebook example for tank class
266602c
@phmbressan
ENH: add upper cap support to Tank class.
1810c06
@phmbressan
FIX: Hemisphere did not receive arguments properly.
f62db89
@phmbressan
ENH: draft of CenterOfMass of LiquidMotor
d2a50ad
@phmbressan
FIX: issue that center of mass was fixed.
4234b63
@phmbressan
Merge branch 'enh/liquid-motors-upper-cap' into enh/liquid_motors_mas…
d8ebf04 
…s_flow_based_tank
@phmbressan
FIX: update to new upper cap and fix 2D Geometry with filling possible.
a817c77
@phmbressan
FIX: inertia tensor gets filling from adequate method.
e872e93
@phmbressan
FIX: update tank_class_usage notebook.
dfdfd2c
@giovaniceotto giovaniceotto added Enhancement New feature or request, including adjustments in current codes Motors Every propulsion related issue or PR labels Oct 9, 2022
@giovaniceotto giovaniceotto added this to the Liquid Motors Support milestone Oct 9, 2022
@giovaniceotto giovaniceotto merged commit 92c2b22 into enh/liquid-motors Oct 9, 2022
@giovaniceotto giovaniceotto deleted the enh/liquid_motors_mass_flow_based_tank branch March 17, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmbressan phmbressan phmbressan approved these changes

Assignees

@MrGribel MrGribel

Labels
Enhancement New feature or request, including adjustments in current codes Motors Every propulsion related issue or PR
Projects
None yet
Milestone
Liquid Motors Support
Development

Successfully merging this pull request may close these issues.
4 participants
@giovaniceotto @phmbressan @MrGribel @lint-action