-
-
Notifications
You must be signed in to change notification settings - Fork 194
REL: Welcome to v0.13.0 #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-Team/RocketPy into enh/automate_dispersion
Conflicts were solved and tests are running, @giovaniceotto and @MateusStano could you guys review this one pls? I'll wait for review of both of you before merging, this is a large PR. |
@Gui-FernandesBR, here is my first review. As this is quite a large PR, I decided to review half of the files today and will review the other half tomorrow, although I have already looked through all the files. Let me know if you have any questions about my comments. |
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: MateusStano <[email protected]>
I'll need one more day to run a couple of checks before we are ready to go. Almost there! |
Here is a problem with the documentation, which can be checked here: https://docs.rocketpy.org/en/develop/user/index.html It seems the Environment Analysis notebook is using H1 headers instead of H2 for Surface Level Analysis, Pressure Level Analysis and Going Further with your Analysis, which causes the main index of the user guide page to get cluttered. Furthermore, the utilities model notebook is out of date regarding the new function When these issues (and the docstring for |
Ok, now tests are passing, and the documentation seems to be good. I also added two notebooks to index.rst file, what I cannot is saying why they weren't included before.
Hey, I don't think it should be mandatory documenting all the new utilities functions on notebooks. Other classes don't even have a notebook.... Therefore, I vote for skipping this one. Maybe in the future we can provide that. The current utilities module notebook seems good to me. Everything else was addressed, at least temporarily. Btw sorry for long commit list, it turns out some tests were passing locally without running so I committed some poor lines thinking that it was running well. |
@Gui-FernandesBR, I have fixed the documentation problem related to headings 1 being used mistakenly. I have also defined which exception to catch in the Once done, I believe we are ready to merge. Quick idea: wait until the weekend (just one day) so that we can host a launch party in our discord channel with the new members so that they can see how a release is done (and so that we can promote this new version together)! |
I got an idea: use quotes to separate objects in the csv file!! |
We are releasing this today! |
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
This is a release PR, all changes were already approved previously ;)
Tests are passing, of course, and docs were updated.
What is the current behavior?
The current master branch is outdated. A lot of changes have been made to develop branch and, finally, I believe that we are able to merge everything to master, upgrading our python package version.
What is the new behavior?
Several changes, really! I will try to summarize them below:
Does this introduce a breaking change?
Other information
Please wait for merge conflicts to be solved before reviewing!