MAINT: move flutter analysis into utilities submodule #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review ✅👌 |
MateusStano
reviewed
Jan 26, 2023
Since I don't if this should be fixed in this PR I'm approving this one because everything else seems good! |
MateusStano
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
Fin Flutter Analysis is polluting the Flight.py file!!!
What is the new behavior?
fin_flutter_analysiswas created inside. Some workarounds to handle with divisions by zero but everything is working as expected!Does this introduce a breaking change?
Other information
Adding an example to the utilities notebook would be interesting, but I do not see reasons for doing it right now at this PR. It is better to give an example after we get near to the next release.