Skip to content

Enh/titles in function plots #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2023
Merged

Conversation

FranzYuri
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

Currently plots using Function's plot1D() and plot2D() methods automatically gives the title for the graphs.

What is the new behavior?

Now plots' titles can be defined either in the construction of the function or via the method setTitle(title)

Does this introduce a breaking change?

  • Yes
  • No

Other information

Enter text here...

@MateusStano MateusStano requested review from ompro07 and Gui-FernandesBR and removed request for giovaniceotto and Gui-FernandesBR January 26, 2023 22:23
Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the documentation of plot1D and plot2D methods. The title is mentioned there and the docs needs some changes to adequate the changes here.

@MateusStano MateusStano mentioned this pull request Jan 30, 2023
15 tasks
FranzYuri and others added 2 commits February 2, 2023 15:36
better description for Title variable

Co-authored-by: MateusStano <[email protected]>
@FranzYuri FranzYuri merged commit d8d3b03 into beta/v1.0.0 Feb 18, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the enh/titles-in-Function-plots branch April 10, 2023 22:50
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.0.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants